Fixing 0 length issue with constructor - #107427
#107427Merged
michaelgsharp merged 3 commits intoSep 16, 2024
dotnet:maindotnet/runtime:mainfrom
michaelgsharp:tensor-span-monotonic-constructormichaelgsharp/runtime:tensor-span-monotonic-constructorCopy head branch name to clipboard
Merged
Fixing 0 length issue with constructor#107427michaelgsharp merged 3 commits intodotnet:maindotnet/runtime:mainfrom michaelgsharp:tensor-span-monotonic-constructormichaelgsharp/runtime:tensor-span-monotonic-constructorCopy head branch name to clipboard
michaelgsharp merged 3 commits into
dotnet:maindotnet/runtime:mainfrom
michaelgsharp:tensor-span-monotonic-constructormichaelgsharp/runtime:tensor-span-monotonic-constructorCopy head branch name to clipboard
Conversation
Contributor
|
This expression can be simplified... if ((maxElements >= span.Length && span.Length != 0) || (span.Length == 0 && maxElements > 0))
ThrowHelper.ThrowArgument_InvalidStridesAndLengths();... to: if (maxElements > 0 && maxElements >= span.Length)
ThrowHelper.ThrowArgument_InvalidStridesAndLengths();Explanation: For simplicity, let's represent if ((a >= b && b != 0) || (b == 0 && a > 0))
error;We can normalize the condition by switching the order of the expressions if ((a >= b && b != 0) || (a > 0 && b == 0))
error;This can be interpreted as: if ((a >= b && b != 0) // a > 0, b > 0, a >= b
|| (a > 0 && b == 0)) // a > 0, b = 0
error;Thus, we are only interested in cases where In the end, we get: if (a > 0 && a >= b)
error;The final expression will look like this: if (maxElements > 0 && maxElements >= span.Length)
ThrowHelper.ThrowArgument_InvalidStridesAndLengths(); |
stephentoub
reviewed
Sep 9, 2024
…ors/netcore/ReadOnlyTensorSpan.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
tannergooding
approved these changes
Sep 16, 2024
Contributor
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10889241013 |
4 tasks
3 tasks
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
* fixing 0 length issue with constructor * Update src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> * comments from PR --------- Co-authored-by: Stephen Toub <stoub@microsoft.com>
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* fixing 0 length issue with constructor * Update src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> * comments from PR --------- Co-authored-by: Stephen Toub <stoub@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106538 by modifying the check in the constructor to also throw an error if the base memory length is 0.