new icon: msdos (original) by MichielPater · Pull Request #726 · devicons/devicon

MichielPater · Jul 7, 2021

And re-sorted icons starting with 'm' alphabetically.

- re-sorted icons starting with 'm' alphabetically

github-actions · Jul 7, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/msdos/msdos-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Added msdos viewport Co-authored-by: David Leal <halfpacho@gmail.com>

Added msdos aliases Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

github-actions · Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Here are the zoomed-in screenshots of the added icons:

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Thomas-Boi · Jul 9, 2021

Seems like the original version is not icon friendly (see peek-bot's image). I'm not sure on the best way to approach this... Can you try stripping the colors manually and upload it as a plain version? Still keep the original but has a plain version that's already simplified and stripped of colors. I'll run the bot again and we'll see how it goes.

github-actions · Jul 21, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/msdos/msdos-line.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/msdos/msdos-plain.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Thomas-Boi

Overall, the SVGs looks good. There are just a few things I'd like to see changed:

Add the line version to the devicon.json's font attribute. This should be font-friendly.
Simplify the plain version a bit more. Currently, it has more than one color. There should only be one color in the whole SVG for the plain version. Pick the primary color and change all the other colors to that.

Co-authored-by: David Leal <halfpacho@gmail.com>

…nto add-msdos

github-actions · Jul 25, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Here are the zoomed-in screenshots of the added icons:

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Panquesito7

Hmm, the version version looks good, but the plain version doesn't look so good. @Thomas-Boi, what do you think we should do? 🤔

…nto add-msdos

Co-authored-by: David Leal <halfpacho@gmail.com>

github-actions · Jul 27, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Here are the zoomed-in screenshots of the added icons:

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Panquesito7

The line version looks good, but the plain doesn't. Could you please fix it?

MichielPater · Jul 27, 2021

The line version looks good, but the plain doesn't. Could you please fix it?

Why doesn't it look good?

Panquesito7 · Jul 28, 2021

The line version looks good, but the plain doesn't. Could you please fix it?

Why doesn't it look good?

I already know what does it say, but for other users, it would be kind of hard to understand, as it looks all black and the letters are very much together. The line version looks very good though. Hope I get to understand, thanks. 🙂

Panquesito7

Actually, never mind. Now that I think about it well, it looks great! I love it. Great work, @MichielPater! Thank you for your patience, dedication, and contributions to our community! 😄👍🎉

Thomas-Boi

Sorry @MichielPater for the late response.

I think the icons and SVGs all look good. I'll merge your changes in. Thank you for your dedication in seeing this through 😃, we really appreciate it.

* new icon: msdos (original) - re-sorted icons starting with 'm' alphabetically * Update icons/msdos/msdos-original.svg Added msdos viewport Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon.json Added msdos aliases Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon.json (fix) Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Update devicon.json (fix) Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * msdos: plain and line added * msdos: added viewboxes for plain and line * msdos: added line to devicon.json and updated plain using single color * msdos-plain: added viewport * Update icons/msdos/msdos-line.svg Co-authored-by: David Leal <halfpacho@gmail.com> * Update icons/msdos/msdos-plain.svg Co-authored-by: David Leal <halfpacho@gmail.com> * Updated devicon.json: changed indentation from tabs to spaces * msdos-plain: Removed inner lines * Update icons/msdos/msdos-plain.svg Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

new icon: msdos (original)

04d394b

- re-sorted icons starting with 'm' alphabetically

MichielPater changed the base branch from master to develop July 7, 2021 18:09

Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Jul 7, 2021

Panquesito7 requested changes Jul 7, 2021

View reviewed changes

Comment thread icons/msdos/msdos-original.svg Outdated

Comment thread devicon.json

MichielPater and others added 2 commits July 7, 2021 21:28

Update icons/msdos/msdos-original.svg

6eb4903

Added msdos viewport Co-authored-by: David Leal <halfpacho@gmail.com>

Update devicon.json

ed79168

Added msdos aliases Co-authored-by: David Leal <halfpacho@gmail.com>

Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 9, 2021

This comment has been minimized.

Sign in to view

Thomas-Boi requested changes Jul 9, 2021

View reviewed changes

Comment thread devicon.json Outdated

Comment thread devicon.json

MichielPater and others added 2 commits July 9, 2021 11:32

Update devicon.json (fix)

72d6944

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

Update devicon.json (fix)

372151e

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 9, 2021

MichielPater added 3 commits July 22, 2021 00:49

msdos: plain and line added

995003e

Merge branch 'add-msdos' with 'develop'

4400adb

Merge branch 'develop' into add-msdos

1f31cc2

MichielPater and others added 2 commits July 22, 2021 01:01

msdos: added viewboxes for plain and line

4175673

Merge branch 'develop' into add-msdos

bb63beb

Thomas-Boi requested changes Jul 22, 2021

View reviewed changes

MichielPater added 2 commits July 22, 2021 08:47

msdos: added line to devicon.json and updated plain using single color

cf13116

msdos-plain: added viewport

30d327c

Panquesito7 requested changes Jul 22, 2021

View reviewed changes

Comment thread icons/msdos/msdos-line.svg Outdated

Comment thread icons/msdos/msdos-plain.svg Outdated

Comment thread devicon.json Outdated

Comment thread devicon.json Outdated

MichielPater and others added 4 commits July 22, 2021 23:35

Update icons/msdos/msdos-line.svg

1122aca

Co-authored-by: David Leal <halfpacho@gmail.com>

Update icons/msdos/msdos-plain.svg

84273b1

Co-authored-by: David Leal <halfpacho@gmail.com>

Updated devicon.json: changed indentation from tabs to spaces

70dc59c

Merge branch 'add-msdos' of https://github.com/MichielPater/devicon i…

dda8b95

…nto add-msdos

Merge branch 'develop' into add-msdos

a598faf

Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 25, 2021

Panquesito7 requested changes Jul 25, 2021

View reviewed changes

MichielPater added 2 commits July 27, 2021 02:16

msdos-plain: Removed inner lines

051118c

Merge branch 'add-msdos' of https://github.com/MichielPater/devicon i…

4075c8c

…nto add-msdos

Panquesito7 reviewed Jul 27, 2021

View reviewed changes

Comment thread icons/msdos/msdos-plain.svg Outdated

Update icons/msdos/msdos-plain.svg

f712d4e

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 27, 2021

Panquesito7 requested changes Jul 27, 2021

View reviewed changes

Panquesito7 approved these changes Jul 30, 2021

View reviewed changes

Panquesito7 requested a review from Thomas-Boi July 30, 2021 00:01

Thomas-Boi approved these changes Aug 7, 2021

View reviewed changes

Merge branch 'develop' into add-msdos

15fdf88

Thomas-Boi merged commit 99dfcf6 into devicons:develop Aug 7, 2021

Thomas-Boi mentioned this pull request Aug 14, 2021

Build preparation for release v2.13.0 #811

Merged

amacado mentioned this pull request Aug 14, 2021

Release v2.13.0 #812

Merged

canaleal mentioned this pull request Nov 6, 2023

update icon: msdos (original, plain, line) #1980

Merged

6 tasks

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

MichielPater commented Jul 7, 2021

Uh oh!

github-actions Bot commented Jul 7, 2021

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2021

Uh oh!

Thomas-Boi commented Jul 9, 2021

Uh oh!

github-actions Bot commented Jul 21, 2021

Uh oh!

Thomas-Boi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 25, 2021

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 27, 2021

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

MichielPater commented Jul 27, 2021

Uh oh!

Panquesito7 commented Jul 28, 2021

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Thomas-Boi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants