update icon: msdos (original, plain, line)#1980
Merged
Merged
update icon: msdos (original, plain, line)#1980
Conversation
lunatic-fox
previously approved these changes
Nov 9, 2023
lunatic-fox
left a comment
Contributor
There was a problem hiding this comment.
Problem solved! 👍🏼
Thank you for this contribution! 🚀
What do you think about remove the padding of those icons @canaleal and @Snailedlt?
Snailedlt
reviewed
Nov 11, 2023
Snailedlt
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but like @lunatic-fox mentioned the padding should be removed :)
Snailedlt
requested changes
Nov 11, 2023
Snailedlt
left a comment
Collaborator
There was a problem hiding this comment.
Size looks good now. I now noticed that msdos-plain has multiple paths though, so those need to be unified
Snailedlt
approved these changes
Nov 12, 2023
Snailedlt
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks good now! Great work as always! 💯
lunatic-fox
approved these changes
Nov 12, 2023
lunatic-fox
left a comment
Contributor
There was a problem hiding this comment.
Great one! 👍🏼
Thank you for this contribution! 🚀
PS: This icon is really nostalgic.
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* Updated icon MSDOS * Update msdos json color * Removed padding for the SVGs * Unified paths for plain svg --------- Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR is related to this issue #1977
Link to prove your SVG is correct and up-to-date.
It's not the official link, but I didn't change the icon from the previous PR.
I updated the color to
#000as that is the most common color in the original logo, and it's already used in the line svg.