Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix typos in user-facing help string and FAQ#4549

Merged
B1ueber2y merged 1 commit into
colmap:maincolmap/colmap:mainfrom
behnamasadi:fix/typos-user-facing-stringsbehnamasadi/colmap:fix/typos-user-facing-stringsCopy head branch name to clipboard
Jul 17, 2026
Merged

Fix typos in user-facing help string and FAQ#4549
B1ueber2y merged 1 commit into
colmap:maincolmap/colmap:mainfrom
behnamasadi:fix/typos-user-facing-stringsbehnamasadi/colmap:fix/typos-user-facing-stringsCopy head branch name to clipboard

Conversation

@behnamasadi

Copy link
Copy Markdown
Contributor

Summary

  • exe/sfm.cc: "follwoing" → "following" in the pose_prior_mapper --overwrite_priors_covariance help text.
  • doc/faq.rst: "conditiions" → "conditions".

- exe/sfm.cc: 'follwoing' -> 'following' in the pose_prior_mapper
  overwrite_priors_covariance option help text.
- doc/faq.rst: 'conditiions' -> 'conditions'.
@B1ueber2y
B1ueber2y enabled auto-merge (squash) July 17, 2026 09:36
@B1ueber2y
B1ueber2y merged commit bd7c30b into colmap:main Jul 17, 2026
15 checks passed
@ahojnnes ahojnnes mentioned this pull request Jul 17, 2026
3 tasks
ahojnnes added a commit that referenced this pull request Jul 17, 2026
Prepares the **4.1.1** patch release by cherry-picking important
bug/build fixes that landed on `main` since `4.1.0`, plus one
previously-unmerged fix. Features, refactors, algorithm changes,
benchmarks, docs-site infra, and dependency upgrades from `main` are
intentionally excluded.

### Included fixes

**Bug / correctness**
- Fix feature matching slowdown from process-global omp critical in
RANSAC (#4553) — restores the ~4–6x matching perf regressed in 4.1.0
- Fix: rescale already-undistorted images when `max_image_size` is
provided (#4512)
- Load mapper database lazily instead of at GUI startup (#4501) *(see
note below)*
- Show image/point viewer metadata when images are missing on disk
(#4546)

**Build / packaging**
- Fix missing SVG icons in Windows binaries (#4496)
- Fix Caspar CUDA build with MSVC forced includes (#4481)
- Fail Caspar build early on CUDA arch < 7.0 (#4495)
- Fix glog color support version detection (#4479)

**GUI**
- Tint UI icons to palette for dark theme legibility (#4478)

**Docs**
- Document quaternion order (wxyz vs xyzw) in `read_rig_config` binding
(#4526)
- Fix stale usage example in `IncrementalMapper` doc comment (#4531)
- Add Fedora build instructions to `install.rst` (#4509)
- Fix typos in user-facing help string and FAQ (#4549)

**Previously unmerged**
- Fix misspelled pycolmap enum name `GPSTransfromEllipsoid` →
`GPSTransformEllipsoid` (#4551)

### ⚠️ Breaking change
#4551 removes `pycolmap.GPSTransfromEllipsoid` (present since ≤4.1.0)
with **no** backward-compatible alias. Downstream code must switch to
`pycolmap.GPSTransformEllipsoid`. This is unusual for a patch release
and must be highlighted in the 4.1.1 release notes.

### Notes
- #4501 required a manual conflict resolution: it was authored on top of
the GUI mapper-selection feature (#4487), which is **not** part of this
patch. The dependency on `UpdateMapperControls()` / `mapper_type_` was
removed and replaced with the 4.1.0 baseline's existing control-state
handling; the net behavior (no database read at GUI startup / project
reset) is preserved.
- All other commits cherry-picked cleanly (`-x` references retained).

### Still TODO before tagging
- [ ] Version bump to 4.1.1
- [ ] CHANGELOG entry (incl. the breaking-change callout)
- [ ] Full build + test run across platforms (CI)

---------

Co-authored-by: WhuAegeanSea <whuaegeansea@gmail.com>
Co-authored-by: Shaohui Liu <b1ueber2y@gmail.com>
Co-authored-by: Behnam Asadi <behnam.asadi@gmail.com>
Co-authored-by: Mohammad Ali <m.aliadnanrauf@gmail.com>
Dawars pushed a commit to Dawars/colmap that referenced this pull request Jul 22, 2026
## Summary

- `exe/sfm.cc`: "follwoing" → "following" in the `pose_prior_mapper`
`--overwrite_priors_covariance` help text.
- `doc/faq.rst`: "conditiions" → "conditions".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.