Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add retries for more reliable file download#4157

Merged
ahojnnes merged 4 commits into
maincolmap/colmap:mainfrom
user/jsch/download-retry-backoffcolmap/colmap:user/jsch/download-retry-backoffCopy head branch name to clipboard
Feb 28, 2026
Merged

Add retries for more reliable file download#4157
ahojnnes merged 4 commits into
maincolmap/colmap:mainfrom
user/jsch/download-retry-backoffcolmap/colmap:user/jsch/download-retry-backoffCopy head branch name to clipboard

Conversation

@ahojnnes

@ahojnnes ahojnnes commented Feb 27, 2026

Copy link
Copy Markdown
Contributor
  • Retries the download of files upon retryable HTTP errors. Parameters configurable through env variables.
  • Should reduce CI failure rates and improve reliability of automatic resource download for users.

@gemini-code-assist

gemini-code-assist Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of file downloads by introducing an automatic retry mechanism. This change aims to improve the reliability of resource acquisition, particularly in environments prone to intermittent network problems, and is expected to reduce CI failure rates. The retry behavior can be customized by setting specific environment variables.

Highlights

  • Download Retries: Implemented a retry mechanism for file downloads to handle transient network issues and server errors.
  • Configurable Parameters: The maximum number of retries and the base wait time between attempts are now configurable via environment variables (COLMAP_DOWNLOAD_MAX_RETRIES and COLMAP_DOWNLOAD_BASE_WAIT_SECONDS).
  • Improved Error Handling: Refined error handling to differentiate between retryable HTTP errors (e.g., 5xx server errors) and non-retryable errors (e.g., 4xx client errors or SSL certificate issues).
Changelog
  • src/colmap/util/file.cc
    • Added retry loop for DownloadFile function to handle failed requests.
    • Introduced GetEnvInt helper function to read integer values from environment variables with default fallbacks.
    • Integrated std::chrono and std::thread for implementing delays between download retries.
    • Modified error handling within DownloadFile to trigger retries for certain CURLcode and HTTP response codes, while failing immediately for others.
Activity
  • No activity has been recorded yet for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 27, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a retry mechanism for file downloads, which is a valuable improvement for reliability, especially in CI environments. The implementation is well-structured, using environment variables for configuration and correctly distinguishing between retryable and non-retryable errors. I have one minor suggestion to improve the exception handling to align better with modern C++ best practices. Overall, this is a solid contribution.

Comment thread src/colmap/util/file.cc Outdated
ahojnnes and others added 3 commits February 27, 2026 21:00
@ahojnnes @gemini-code-assist
Update file.cc
aab7f29 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ahojnnes
d
c1e6efd
@ahojnnes
Merge branch 'user/jsch/download-retry-backoff' of https://github.com…
17073c8 
…/colmap/colmap into user/jsch/download-retry-backoff
@ahojnnes
ahojnnes merged commit f5b3d3b into main Feb 28, 2026
14 checks passed
@ahojnnes
ahojnnes deleted the user/jsch/download-retry-backoff branch February 28, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B1ueber2y B1ueber2y B1ueber2y approved these changes
@sarlinpe sarlinpe Awaiting requested review from sarlinpe
@lpanaf lpanaf Awaiting requested review from lpanaf
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahojnnes @B1ueber2y
Morty Proxy This is a proxified and sanitized view of the page, visit original site.