Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Enforce compile-time type checking for option registration#4148

Merged
ahojnnes merged 1 commit into
colmap:maincolmap/colmap:mainfrom
StonerLing:fix/template-unsupported-typeStonerLing/colmap:fix/template-unsupported-typeCopy head branch name to clipboard
Feb 27, 2026
Merged

Enforce compile-time type checking for option registration#4148
ahojnnes merged 1 commit into
colmap:maincolmap/colmap:mainfrom
StonerLing:fix/template-unsupported-typeStonerLing/colmap:fix/template-unsupported-typeCopy head branch name to clipboard

Conversation

@StonerLing

@StonerLing StonerLing commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #4147

Unsupported option types now fail at compile time via static_assert, making errors easier to diagnose and preventing unreachable runtime error paths.

@gemini-code-assist

gemini-code-assist Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness of option registration by shifting type validation from runtime to compile-time. This change ensures that unsupported option types are detected during compilation, preventing potential runtime crashes and simplifying debugging. It also includes minor type adjustments in related executable files to align with these new compile-time checks, improving overall type safety.

Highlights

  • Compile-time Type Checking: Implemented compile-time type checking for option registration, replacing runtime fatal errors with static_assert for unsupported option types.
  • Type Adjustments: Adjusted integer types from size_t to int in image.cc and sfm.cc to ensure compatibility and prevent potential issues with option registration.
  • Metaprogramming Utility: Introduced a new always_false template struct in types.h to facilitate the use of static_assert with dependent types.
Changelog
  • src/colmap/controllers/base_option_manager.h
    • Replaced a runtime LOG(FATAL_THROW) with a compile-time static_assert for handling unsupported option types during registration.
  • src/colmap/exe/image.cc
    • Changed the type of min_num_observations from size_t to int.
    • Updated the comparison image.NumPoints3D() >= min_num_observations to include a static_cast<size_t> for the min_num_observations variable.
  • src/colmap/exe/sfm.cc
    • Changed the type of min_track_len from size_t to int.
  • src/colmap/util/types.h
    • Added a new template struct always_false which inherits from std::false_type, intended for use with static_assert.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 27, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves type safety for option registration by replacing a runtime error for unsupported types with a compile-time static_assert. This is a valuable change that makes errors easier to diagnose. As a consequence of size_t not being a supported option type, several options were changed from size_t to int. My review includes a comment discussing a potential issue with this change and suggests an alternative approach to consider.

Comment thread src/colmap/controllers/base_option_manager.h
@ahojnnes

ahojnnes commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Oh, thank you for this fix!

@ahojnnes
ahojnnes enabled auto-merge (squash) February 27, 2026 07:11
@ahojnnes
ahojnnes merged commit 04f28b8 into colmap:main Feb 27, 2026
14 checks passed
@StonerLing
StonerLing deleted the fix/template-unsupported-type branch February 27, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is point_filtering broken in 3.14?

2 participants

@StonerLing @ahojnnes
Morty Proxy This is a proxified and sanitized view of the page, visit original site.