Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Parse unregistered config options with warning instead of error#4140

Merged
ahojnnes merged 5 commits into
colmap:maincolmap/colmap:mainfrom
StonerLing:feature/allow-read-unregistered-optionsStonerLing/colmap:feature/allow-read-unregistered-optionsCopy head branch name to clipboard
Feb 26, 2026
Merged

Parse unregistered config options with warning instead of error#4140
ahojnnes merged 5 commits into
colmap:maincolmap/colmap:mainfrom
StonerLing:feature/allow-read-unregistered-optionsStonerLing/colmap:feature/allow-read-unregistered-optionsCopy head branch name to clipboard

Conversation

@StonerLing

@StonerLing StonerLing commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Enable allow_unregistered when parsing config files, unregistered options are preserved and logged as warnings instead of errors.

This is necessary because many custom options are defined within COLMAP’s controllers and are not pre-registered in the OptionManager. Without enabling allow_unregistered, these controller-specific parameters would cause parsing failures.

@gemini-code-assist

gemini-code-assist Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @StonerLing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the configuration parsing mechanism to gracefully handle unrecognized options in config files. Instead of terminating with an error, the system will now log a warning for any unknown options encountered, while still processing the valid ones. This change improves the robustness and user-friendliness of configuration loading, allowing for more flexible and forward-compatible configuration files.

Highlights

  • Configuration Parsing Flexibility: Introduced an allow_unregistered boolean parameter to the Read and ReRead methods of BaseOptionManager and OptionManager, enabling more flexible handling of configuration files.
  • Warning for Unrecognized Options: Modified the configuration parsing logic to log unrecognized options as warnings when allow_unregistered is true, instead of terminating with an error.
  • New Test Case: Added a new test, ReadWithUnregisteredOptions, to base_option_manager_test.cc to validate the correct behavior of parsing config files with unregistered options.
Changelog
  • src/colmap/controllers/base_option_manager.cc
    • Updated Read and ReRead methods to accept an allow_unregistered boolean parameter.
    • Implemented logic within Read to use config::parse_config_file with the new allow_unregistered flag.
    • Added a loop to log warnings for any unregistered options found when allow_unregistered is true.
  • src/colmap/controllers/base_option_manager.h
    • Modified the declarations of Read and ReRead to include the allow_unregistered parameter, defaulting to true.
  • src/colmap/controllers/base_option_manager_test.cc
    • Included the <fstream> header.
    • Added a new test ReadWithUnregisteredOptions to verify that unregistered options are handled correctly (warned when allowed, error when not allowed).
  • src/colmap/controllers/option_manager.cc
    • Updated the Read method to accept allow_unregistered and pass it to the base class's Read method.
  • src/colmap/controllers/option_manager.h
    • Modified the declaration of Read to include the allow_unregistered parameter, defaulting to true.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 25, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the configuration parsing to allow unregistered options, logging them as warnings instead of throwing errors. The change is implemented by adding an allow_unregistered parameter to the Read methods in BaseOptionManager and OptionManager, with a default that enables this new, more permissive behavior. The implementation is clean, correctly using boost::program_options to detect and report unrecognized options. A new unit test effectively verifies the functionality. The changes are well-executed and improve the user experience when dealing with configuration files.

ahojnnes
ahojnnes approved these changes Feb 25, 2026
View reviewed changes

@ahojnnes ahojnnes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread src/colmap/controllers/base_option_manager.cc Outdated
Comment thread src/colmap/controllers/base_option_manager.cc Outdated
@ahojnnes
ahojnnes enabled auto-merge (squash) February 26, 2026 09:43
@ahojnnes
ahojnnes merged commit 1328e0a into colmap:main Feb 26, 2026
15 of 16 checks passed
@StonerLing
StonerLing deleted the feature/allow-read-unregistered-options branch February 27, 2026 01:01
@StonerLing StonerLing mentioned this pull request Mar 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StonerLing @ahojnnes
Morty Proxy This is a proxified and sanitized view of the page, visit original site.