Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Switch to perform clustering on all registered frames#4007

Merged
lpanaf merged 4 commits into
maincolmap/colmap:mainfrom
lpanaf/prune_all_registered_v2colmap/colmap:lpanaf/prune_all_registered_v2Copy head branch name to clipboard
Jan 15, 2026
Merged

Switch to perform clustering on all registered frames#4007
lpanaf merged 4 commits into
maincolmap/colmap:mainfrom
lpanaf/prune_all_registered_v2colmap/colmap:lpanaf/prune_all_registered_v2Copy head branch name to clipboard

Conversation

@lpanaf

@lpanaf lpanaf commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator

Instead of clustering only the largest connected component, performs it over all frames. This would be helpful if the generated reconstruction contains several disconnected components.

@lpanaf
lpanaf requested review from B1ueber2y and ahojnnes and removed request for ahojnnes January 14, 2026 14:54

@B1ueber2y B1ueber2y left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Does it make sense to add a test with a multi-CC input?

Comment thread src/colmap/scene/reconstruction_clustering.cc
Comment thread src/glomap/processors/reconstruction_pruning.h Outdated
@lpanaf
lpanaf requested a review from ahojnnes January 14, 2026 15:49
@lpanaf

lpanaf commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks. Does it make sense to add a test with a multi-CC input?

I will add it to the PR with the test functions.

@lpanaf
lpanaf requested a review from B1ueber2y January 14, 2026 16:24
@lpanaf lpanaf closed this Jan 14, 2026
@lpanaf lpanaf reopened this Jan 14, 2026

@ahojnnes ahojnnes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@lpanaf lpanaf changed the title Switch to perform pruning on all registered frames Switch to perform clustering on all registered frames Jan 15, 2026
@lpanaf
lpanaf enabled auto-merge (squash) January 15, 2026 12:35
@lpanaf
lpanaf merged commit 7b36775 into main Jan 15, 2026
14 checks passed
@lpanaf
lpanaf deleted the lpanaf/prune_all_registered_v2 branch January 15, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.