Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Switch to Python 3.11 in the PR build. Disable mypy for Python 3.10. #3998

Merged
B1ueber2y merged 8 commits into
maincolmap/colmap:mainfrom
shaohui/fix_stubs_for_eigencolmap/colmap:shaohui/fix_stubs_for_eigenCopy head branch name to clipboard
Jan 12, 2026
Merged

Switch to Python 3.11 in the PR build. Disable mypy for Python 3.10. #3998
B1ueber2y merged 8 commits into
maincolmap/colmap:mainfrom
shaohui/fix_stubs_for_eigencolmap/colmap:shaohui/fix_stubs_for_eigenCopy head branch name to clipboard

Conversation

@B1ueber2y

@B1ueber2y B1ueber2y commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

To avoid type annotation bug in numpy < 2.3.0.

@B1ueber2y
B1ueber2y marked this pull request as draft January 12, 2026 14:47
Comment thread python/generate_stubs_test.py Outdated
@B1ueber2y

B1ueber2y commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

Managed to reproduce the errors with the tests from CI (seems to fail in both ubuntu 24.04 and macos-15 arm64): https://github.com/colmap/colmap/actions/runs/20923717516/job/60115792676.

Strange enough, I cannot reproduce this issue locally.

Comment thread python/generate_stubs.sh Outdated
@B1ueber2y
B1ueber2y marked this pull request as ready for review January 12, 2026 17:28
@B1ueber2y B1ueber2y changed the title Fix numpy array type annotations in generated stubs. Switch to Python 3.11 in the PR build. Add a test for the annotation bug for numpy < 2.3.0. Jan 12, 2026
Comment thread python/generate_stubs_test.py Outdated
@B1ueber2y B1ueber2y changed the title Switch to Python 3.11 in the PR build. Add a test for the annotation bug for numpy < 2.3.0. Switch to Python 3.11 in the PR build. Jan 12, 2026
@B1ueber2y B1ueber2y changed the title Switch to Python 3.11 in the PR build. Switch to Python 3.11 in the PR build. Disable mypy for Python 3.10. Jan 12, 2026
@B1ueber2y
B1ueber2y enabled auto-merge (squash) January 12, 2026 17:41
@B1ueber2y
B1ueber2y requested a review from sarlinpe January 12, 2026 17:42
@B1ueber2y
B1ueber2y merged commit 1be5612 into main Jan 12, 2026
14 checks passed
@B1ueber2y
B1ueber2y deleted the shaohui/fix_stubs_for_eigen branch January 12, 2026 18:17
@ahojnnes

Copy link
Copy Markdown
Contributor

I am confused. So why did this not trigger before as we have 3.10 running in CI? What's the concrete issue? If we don't test 3.10 in CI anymore, I expect we'll frequently break master because changes slip through that will be incompatible with 3.10?

@B1ueber2y

Copy link
Copy Markdown
Contributor Author

I am confused. So why did this not trigger before as we have 3.10 running in CI? What's the concrete issue? If we don't test 3.10 in CI anymore, I expect we'll frequently break master because changes slip through that will be incompatible with 3.10?

We did not hit the type annotation bug before. Alternatively, what about enabling both 3.10 and 3.11 in the PR, but skip mypy for 3.10? This will make the CI run a bit longer.

@ahojnnes

Copy link
Copy Markdown
Contributor

Let's see how it goes. In the first breakage in master, let's reenable 3.10 in PR checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.