Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Catch AggregateException for ThreadPool.#3875

Merged
B1ueber2y merged 11 commits into
maincolmap/colmap:mainfrom
tmp/aggregate_exceptioncolmap/colmap:tmp/aggregate_exceptionCopy head branch name to clipboard
Dec 27, 2025
Merged

Catch AggregateException for ThreadPool.#3875
B1ueber2y merged 11 commits into
maincolmap/colmap:mainfrom
tmp/aggregate_exceptioncolmap/colmap:tmp/aggregate_exceptionCopy head branch name to clipboard

Conversation

@B1ueber2y

Copy link
Copy Markdown
Contributor

To make the naive try catch work again. The current PR version wont drain all errors at try catch.

@B1ueber2y
B1ueber2y requested a review from ahojnnes December 27, 2025 10:30
Base automatically changed from user/jsch/thread-pool-wait-exc to main December 27, 2025 12:45

@ahojnnes ahojnnes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

Comment thread src/colmap/util/threading.cc
Comment thread src/colmap/util/threading.h Outdated
@B1ueber2y
B1ueber2y enabled auto-merge (squash) December 27, 2025 15:51
@B1ueber2y
B1ueber2y merged commit 06c724b into main Dec 27, 2025
14 checks passed
@B1ueber2y
B1ueber2y deleted the tmp/aggregate_exception branch December 27, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.