Improve stability of visual index spatial verification test#3874
Merged
ahojnnes merged 1 commit intoDec 27, 2025
maincolmap/colmap:mainfrom
user/jsch/visual-index-test-fixcolmap/colmap:user/jsch/visual-index-test-fixCopy head branch name to clipboard
Merged
Improve stability of visual index spatial verification test#3874ahojnnes merged 1 commit intomaincolmap/colmap:mainfrom user/jsch/visual-index-test-fixcolmap/colmap:user/jsch/visual-index-test-fixCopy head branch name to clipboard
ahojnnes merged 1 commit into
maincolmap/colmap:mainfrom
user/jsch/visual-index-test-fixcolmap/colmap:user/jsch/visual-index-test-fixCopy head branch name to clipboard
Conversation
ahojnnes
enabled auto-merge (squash)
December 27, 2025 08:32
B1ueber2y
approved these changes
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building a faiss index doesn't appear to be perfectly deterministic despite using a single thread. Rarely the test thus still fails under Windows. Increasing the number of visual words reduces the chance for random descriptor mismatches.