Use temporary storage for camera centers in global positioning.#3854
Merged
Merged
Use temporary storage for camera centers in global positioning.#3854
Conversation
ahojnnes
approved these changes
Dec 26, 2025
B1ueber2y
changed the base branch from
features/use_reconstruction_in_glomap
to
main
December 26, 2025 11:49
B1ueber2y
enabled auto-merge (squash)
December 26, 2025 11:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent on #3853
The previous logic of first resetting translation to camera center and then converting it back is horrendously unsafe, both in terms of logic and readability.