Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Throw exception if any camera in the rig does not exist in the reconstruction.#3564

Merged
B1ueber2y merged 5 commits into
colmap:maincolmap/colmap:mainfrom
B1ueber2y:fix/add_rigB1ueber2y/colmap:fix/add_rigCopy head branch name to clipboard
Aug 14, 2025
Merged

Throw exception if any camera in the rig does not exist in the reconstruction.#3564
B1ueber2y merged 5 commits into
colmap:maincolmap/colmap:mainfrom
B1ueber2y:fix/add_rigB1ueber2y/colmap:fix/add_rigCopy head branch name to clipboard

Conversation

@B1ueber2y

Copy link
Copy Markdown
Contributor

No description provided.

@B1ueber2y
B1ueber2y requested review from ahojnnes and sarlinpe August 14, 2025 15:53
@B1ueber2y

B1ueber2y commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

Actually, should we enforce AddCamera to be always called before AddRig? Fixing the order of adding objects is the only way that this consistency can be tested. Any opinions?

@ahojnnes ahojnnes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great improvement. Some small suggestions.

Comment thread src/colmap/scene/reconstruction.cc Outdated
Comment thread src/colmap/scene/reconstruction.cc Outdated
Comment thread src/colmap/scene/reconstruction.cc Outdated
@B1ueber2y
B1ueber2y merged commit 2d290fe into colmap:main Aug 14, 2025
13 checks passed
@B1ueber2y
B1ueber2y deleted the fix/add_rig branch August 15, 2025 12:38
tavislocus pushed a commit to tavislocus/colmap_6dof that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.