Speedup database reads of rigs/frames with single SQL outer join query#3387
Merged
ahojnnes merged 7 commits intoJun 10, 2025
maincolmap/colmap:mainfrom
user/jsch/database-read-rig-frame-speedupcolmap/colmap:user/jsch/database-read-rig-frame-speedupCopy head branch name to clipboard
Merged
Speedup database reads of rigs/frames with single SQL outer join query#3387ahojnnes merged 7 commits intomaincolmap/colmap:mainfrom user/jsch/database-read-rig-frame-speedupcolmap/colmap:user/jsch/database-read-rig-frame-speedupCopy head branch name to clipboard
ahojnnes merged 7 commits into
maincolmap/colmap:mainfrom
user/jsch/database-read-rig-frame-speedupcolmap/colmap:user/jsch/database-read-rig-frame-speedupCopy head branch name to clipboard
Conversation
…ithub.com/colmap/colmap into user/jsch/database-read-rig-frame-speedup
paulinus
suggested changes
Jun 10, 2025
paulinus
left a comment
There was a problem hiding this comment.
LGTM, just two minor potential issues that could break if SQL stops sorting rows or if the receiver of the moved objects modifies them.
paulinus
approved these changes
Jun 10, 2025
ahojnnes
enabled auto-merge (squash)
June 10, 2025 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing the code, I got lazy and thought it would be fast enough to use separate queries per frame/rigs. This can be done with a single query by joining the rigs/rig_sensors and frames/frame_data tables.Supersedes #3386.