Add conversion between LLA and UTM coords.#3030
Merged
ahojnnes merged 6 commits intoDec 11, 2024
colmap:maincolmap/colmap:mainfrom
StonerLing:stonerling/feature/lla_utm_conversionStonerLing/colmap:stonerling/feature/lla_utm_conversionCopy head branch name to clipboard
Merged
Add conversion between LLA and UTM coords.#3030ahojnnes merged 6 commits intocolmap:maincolmap/colmap:mainfrom StonerLing:stonerling/feature/lla_utm_conversionStonerLing/colmap:stonerling/feature/lla_utm_conversionCopy head branch name to clipboard
ahojnnes merged 6 commits into
colmap:maincolmap/colmap:mainfrom
StonerLing:stonerling/feature/lla_utm_conversionStonerLing/colmap:stonerling/feature/lla_utm_conversionCopy head branch name to clipboard
Conversation
StonerLing
commented
Dec 11, 2024
Contributor
- Add feature mentioned in Add Lat/Lon to UTM Conversion Feature #3017
- Add related unit tests, which have been passed on my machine.
ahojnnes
reviewed
Dec 11, 2024
ahojnnes
left a comment
Contributor
There was a problem hiding this comment.
Thank you, this looks great. Thanks also for writing a nice set of tests and comments. I have a few minor comments. I assume you would follow up with exposing this functionality in the CLI and other relevant places in another PR?
Contributor
Author
|
Thanks a lot for the detailed review. I’ve implemented all of your suggestions and pushed the changes.
I will try to do that in a new PR. |
StonerLing
force-pushed
the
stonerling/feature/lla_utm_conversion
branch
from
December 11, 2024 09:12
498b175 to
f80f355
Compare
sarlinpe
reviewed
Dec 11, 2024
ahojnnes
reviewed
Dec 11, 2024
StonerLing
force-pushed
the
stonerling/feature/lla_utm_conversion
branch
from
December 11, 2024 10:23
782c6e0 to
59c00ef
Compare
ahojnnes
approved these changes
Dec 11, 2024
ahojnnes
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks good to me.
HernandoR
pushed a commit
to HernandoR/colmap
that referenced
this pull request
Dec 30, 2024
- Add feature mentioned in colmap#3017 - Add related unit tests, which have been passed on my machine. --------- Co-authored-by: Huizhi Ling <linghuizhi@xaggeo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.