Custom macro for enum to string support#2918
Merged
B1ueber2y merged 21 commits intoNov 18, 2024
colmap:maincolmap/colmap:mainfrom
B1ueber2y:features/enum_to_stringB1ueber2y/colmap:features/enum_to_stringCopy head branch name to clipboard
Merged
Custom macro for enum to string support#2918B1ueber2y merged 21 commits intocolmap:maincolmap/colmap:mainfrom B1ueber2y:features/enum_to_stringB1ueber2y/colmap:features/enum_to_stringCopy head branch name to clipboard
B1ueber2y merged 21 commits into
colmap:maincolmap/colmap:mainfrom
B1ueber2y:features/enum_to_stringB1ueber2y/colmap:features/enum_to_stringCopy head branch name to clipboard
Conversation
Contributor
Author
|
Also it currently only supports enum class. Need to support enum as well (should be straightforward). |
B1ueber2y
marked this pull request as draft
November 18, 2024 12:17
Contributor
Author
This is supported: 7e34979 |
B1ueber2y
marked this pull request as ready for review
November 18, 2024 15:45
ahojnnes
reviewed
Nov 18, 2024
ahojnnes
reviewed
Nov 18, 2024
ahojnnes
reviewed
Nov 18, 2024
ahojnnes
approved these changes
Nov 18, 2024
ahojnnes
left a comment
Contributor
There was a problem hiding this comment.
Looks great to me, thanks.
ahojnnes
reviewed
Nov 18, 2024
B1ueber2y
enabled auto-merge (squash)
November 18, 2024 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I adapted only a few for now as examples. If we are happy with it we could apply on all enum classes.