Initialize glog in custom gmock main function#2916
Merged
ahojnnes merged 7 commits intoNov 19, 2024
maincolmap/colmap:mainfrom
user/jsch/gtest-main-glog-initcolmap/colmap:user/jsch/gtest-main-glog-initCopy head branch name to clipboard
Merged
Initialize glog in custom gmock main function#2916ahojnnes merged 7 commits intomaincolmap/colmap:mainfrom user/jsch/gtest-main-glog-initcolmap/colmap:user/jsch/gtest-main-glog-initCopy head branch name to clipboard
ahojnnes merged 7 commits into
maincolmap/colmap:mainfrom
user/jsch/gtest-main-glog-initcolmap/colmap:user/jsch/gtest-main-glog-initCopy head branch name to clipboard
Conversation
Member
|
Nice! Are the test failures related? Does it mean that tests have been silently failing on Windows? |
Contributor
Author
I am afraid that this might be the case. I don't have access to a Windows machine right now though :-) Will need to setup a virtual machine to debug the issues. |
Contributor
Author
|
@sarlinpe I fixed the Windows test failures. They were related in the sense that we didn't fail on test failures under Windows before the custom gtest main function. |
ahojnnes
commented
Nov 19, 2024
sarlinpe
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the custom main function introduced in this PR, we get warnings about glog not being initialized, since the default gtest/gmock main functions do not initialize glog.