Fix rare deadlock during matching due to concurrent database access#2876
Merged
ahojnnes merged 1 commit intoNov 2, 2024
maincolmap/colmap:mainfrom
user/jsch/deadlock-database-transactioncolmap/colmap:user/jsch/deadlock-database-transactionCopy head branch name to clipboard
Merged
Fix rare deadlock during matching due to concurrent database access#2876ahojnnes merged 1 commit intomaincolmap/colmap:mainfrom user/jsch/deadlock-database-transactioncolmap/colmap:user/jsch/deadlock-database-transactionCopy head branch name to clipboard
ahojnnes merged 1 commit into
maincolmap/colmap:mainfrom
user/jsch/deadlock-database-transactioncolmap/colmap:user/jsch/deadlock-database-transactionCopy head branch name to clipboard
Conversation
sarlinpe
approved these changes
Nov 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out one cannot concurrent read from the database and begin a transaction. This could happen in rare cases during vocabulary tree based matching, as the querying of the vocabulary tree is performed concurrently to the main matching controller thread. In this case, one thread might simultaneously read and begin a transaction. This causes a deadlock if unlucky. With this PR, this cannot happen anymore.