Reconstruction reader/writer tests and scene class repr#2842
Merged
ahojnnes merged 16 commits intoOct 23, 2024
maincolmap/colmap:mainfrom
user/jsch/reader-writer-testcolmap/colmap:user/jsch/reader-writer-testCopy head branch name to clipboard
Merged
Reconstruction reader/writer tests and scene class repr#2842ahojnnes merged 16 commits intomaincolmap/colmap:mainfrom user/jsch/reader-writer-testcolmap/colmap:user/jsch/reader-writer-testCopy head branch name to clipboard
ahojnnes merged 16 commits into
maincolmap/colmap:mainfrom
user/jsch/reader-writer-testcolmap/colmap:user/jsch/reader-writer-testCopy head branch name to clipboard
Conversation
B1ueber2y
reviewed
Oct 21, 2024
B1ueber2y
approved these changes
Oct 21, 2024
sarlinpe
approved these changes
Oct 21, 2024
ahojnnes
enabled auto-merge (squash)
October 23, 2024 16:21
ahojnnes
pushed a commit
that referenced
this pull request
Oct 25, 2024
#2842 removed the custom `__repr__` for some objects like `Image`. Pycolmap then falls back to enumerating all the attributes, which is suboptimal - for example for `Image` we don't want to print all 2D points to void bloating the console output. This PR recovers the previous behavior for objects for which `stringstream << obj` is defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.