Return success status in low-level triangulation functions#2834
Merged
ahojnnes merged 3 commits intoOct 16, 2024
maincolmap/colmap:mainfrom
user/jsch/triangulation-successcolmap/colmap:user/jsch/triangulation-successCopy head branch name to clipboard
Merged
Return success status in low-level triangulation functions#2834ahojnnes merged 3 commits intomaincolmap/colmap:mainfrom user/jsch/triangulation-successcolmap/colmap:user/jsch/triangulation-successCopy head branch name to clipboard
ahojnnes merged 3 commits into
maincolmap/colmap:mainfrom
user/jsch/triangulation-successcolmap/colmap:user/jsch/triangulation-successCopy head branch name to clipboard
Conversation
sarlinpe
reviewed
Oct 13, 2024
ahojnnes
enabled auto-merge (squash)
October 15, 2024 10:25
sarlinpe
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More robustly handle degenerate configurations. Noticed a rare edge case during some tests. Should barely make a difference in practice but avoids issues when using the low-level functions in new places.