Improved pycolmap coverage and docs#2752
Merged
sarlinpe merged 4 commits intoSep 5, 2024
maincolmap/colmap:mainfrom
sarlinpe/better-binding-doccolmap/colmap:sarlinpe/better-binding-docCopy head branch name to clipboard
Merged
Improved pycolmap coverage and docs#2752sarlinpe merged 4 commits intomaincolmap/colmap:mainfrom sarlinpe/better-binding-doccolmap/colmap:sarlinpe/better-binding-docCopy head branch name to clipboard
sarlinpe merged 4 commits into
maincolmap/colmap:mainfrom
sarlinpe/better-binding-doccolmap/colmap:sarlinpe/better-binding-docCopy head branch name to clipboard
Conversation
sarlinpe
requested review from
B1ueber2y and
ahojnnes
and removed request for
ahojnnes
September 4, 2024 21:59
sarlinpe
enabled auto-merge (squash)
September 4, 2024 22:00
ahojnnes
reviewed
Sep 5, 2024
| ss << "PosePrior(" | ||
| << "position=[" << self.position.format(vec_fmt) << "], " | ||
| << "system=" << py::str(py::cast(self.coordinate_system)) << ")"; | ||
| << "coordinates=" << py::str(py::cast(self.coordinate_system)) |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| << "coordinates=" << py::str(py::cast(self.coordinate_system)) | |
| << "coordinate_system=" << py::str(py::cast(self.coordinate_system)) |
ahojnnes
reviewed
Sep 5, 2024
| "image_id"_a) | ||
| .def("complete_image", | ||
| &IncrementalTriangulator::CompleteImage, | ||
| "optionts"_a, |
ahojnnes
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.