Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix table mangled by clang-format#2710

Merged
ahojnnes merged 1 commit into
colmap:maincolmap/colmap:mainfrom
sweber1:patchsweber1/colmap:patchCopy head branch name to clipboard
Aug 15, 2024
Merged

Fix table mangled by clang-format#2710
ahojnnes merged 1 commit into
colmap:maincolmap/colmap:mainfrom
sweber1:patchsweber1/colmap:patchCopy head branch name to clipboard

Conversation

@sweber1

@sweber1 sweber1 commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

Noticed a table in exe/feature.h was mangled. Happened when clang-format options where simplified in #1950.

This reverts it to what it used to look like:

// -----------------------------------------------------------------------------------
// | | ImageReaderOptions |
// | CameraMode | single_camera | single_camera_per_folder | single_camera_per_image |
// |------------|---------------|--------------------------|-------------------------|
// | AUTO | false | false | false |
// | SINGLE | true | false | false |
// | PER_FOLDER | false | true | false |
// | PER_IMAGE | false | false | true |
// -----------------------------------------------------------------------------------
and turns off clang-format for those lines.

@ahojnnes

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.