Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix: sequential matcher overlap number should be inclusive#2701

Merged
ahojnnes merged 3 commits into
colmap:maincolmap/colmap:mainfrom
flm8620:mainflm8620/colmap:mainCopy head branch name to clipboard
Aug 14, 2024
Merged

Fix: sequential matcher overlap number should be inclusive#2701
ahojnnes merged 3 commits into
colmap:maincolmap/colmap:mainfrom
flm8620:mainflm8620/colmap:mainCopy head branch name to clipboard

Conversation

@flm8620

@flm8620 flm8620 commented Aug 11, 2024

Copy link
Copy Markdown
Contributor

This bug dates back to commit
Improve code of feature matchers

According to this doc in colmap/src/colmap/controllers/feature_matching.h:

// Sequentially match images within neighborhood:
//
// +-------------------------------+-----------------------> images[i]
//                      ^          |           ^
//                      |   Current image[i]   |
//                      |          |           |
//                      +----------+-----------+
//                                 |
//                        Match image_i against
//
//                    image_[i - o, i + o]        with o = [1 .. overlap]
//                    image_[i - 2^o, i + 2^o]    (for quadratic overlap)
//
// Sequential order is determined based on the image names in ascending order.
//
// Invoke loop detection if `(i mod loop_detection_period) == 0`, retrieve
// most similar `loop_detection_num_images` images from vocabulary tree,
// and perform matching and verification.
std::unique_ptr<Thread> CreateSequentialFeatureMatcher(
    const SequentialMatchingOptions& options,
    const SiftMatchingOptions& matching_options,
    const TwoViewGeometryOptions& geometry_options,
    const std::string& database_path);

As described in the above doc, also intruitively, If we give overlap 3 for sequential matcher, without the quadratic option, the image id 100 should be matched to
97, 98, 99, and 101, 102, 103, which incluses 97, 103.

@ahojnnes
ahojnnes enabled auto-merge (squash) August 14, 2024 11:46
@ahojnnes

Copy link
Copy Markdown
Contributor

Thanks, the fix looks correct.

@ahojnnes

Copy link
Copy Markdown
Contributor

I'll follow up with some extra fix and a few basic tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.