Fix optimal point algorithm#2640
Merged
ahojnnes merged 4 commits intoJul 13, 2024
colmap:maincolmap/colmap:mainfrom
morrishelle:optimal_observationsmorrishelle/colmap:optimal_observationsCopy head branch name to clipboard
Merged
Fix optimal point algorithm#2640ahojnnes merged 4 commits intocolmap:maincolmap/colmap:mainfrom morrishelle:optimal_observationsmorrishelle/colmap:optimal_observationsCopy head branch name to clipboard
ahojnnes merged 4 commits into
colmap:maincolmap/colmap:mainfrom
morrishelle:optimal_observationsmorrishelle/colmap:optimal_observationsCopy head branch name to clipboard
Conversation
…n Made Easy' by P. Lindstrom
morrishelle
marked this pull request as draft
July 8, 2024 12:44
…n Made Easy' by P. Lindstrom
morrishelle
marked this pull request as ready for review
July 8, 2024 12:54
…n Made Easy' by P. Lindstrom
ahojnnes
reviewed
Jul 8, 2024
ahojnnes
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the fix. I'll need to wait with merging until we have resolved issues in the CI system.
ahojnnes
approved these changes
Jul 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns the implementation of FindOptimalImageObservations() with the algorithm listing 'niter2' from the paper 'Triangulation Made Easy' by P. Lindstrom [1].
[1] Lindstrom, Peter. (2010). Triangulation Made Easy. Proceedings / CVPR, IEEE Computer Society Conference on Computer Vision and Pattern Recognition. IEEE Computer Society Conference on Computer Vision and Pattern Recognition. 1554-1561. 10.1109/CVPR.2010.5539785.