Allow getters FocalLength{X,Y} for isotropic models#2301
Merged
ahojnnes merged 3 commits intoDec 19, 2023
colmap:maincolmap/colmap:mainfrom
sarlinpe:sarlinpe/focal-length-xysarlinpe/colmap:sarlinpe/focal-length-xyCopy head branch name to clipboard
Merged
Allow getters FocalLength{X,Y} for isotropic models#2301ahojnnes merged 3 commits intocolmap:maincolmap/colmap:mainfrom sarlinpe:sarlinpe/focal-length-xysarlinpe/colmap:sarlinpe/focal-length-xyCopy head branch name to clipboard
ahojnnes merged 3 commits into
colmap:maincolmap/colmap:mainfrom
sarlinpe:sarlinpe/focal-length-xysarlinpe/colmap:sarlinpe/focal-length-xyCopy head branch name to clipboard
Conversation
ahojnnes
reviewed
Dec 18, 2023
Contributor
|
DCHECK has no runtime overhead when compiling in release (non-debug) mode. |
Co-authored-by: Johannes Schönberger <jsch@demuc.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the higher level logic, especially for Python users (colmap/pycolmap#199).
By the way: what is the rationale for using debug checks
DCHECK_*instead ofCHECK_*inscene/camera.hgetters and setters?