Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Bugfix] Properly handle CGAL_ENABLED#2149

Merged
ahojnnes merged 3 commits into
colmap:maincolmap/colmap:mainfrom
sarlinpe:paul/add-cgal-enabledsarlinpe/colmap:paul/add-cgal-enabledCopy head branch name to clipboard
Sep 10, 2023
Merged

[Bugfix] Properly handle CGAL_ENABLED#2149
ahojnnes merged 3 commits into
colmap:maincolmap/colmap:mainfrom
sarlinpe:paul/add-cgal-enabledsarlinpe/colmap:paul/add-cgal-enabledCopy head branch name to clipboard

Conversation

@sarlinpe

@sarlinpe sarlinpe commented Sep 7, 2023

Copy link
Copy Markdown
Member
  • Add missing COLMAP_CGAL_ENABLED: since 4afd5d9 CGAL is currently never enabled
  • Fix build error when CGAL_ENABLED=OFF

@sarlinpe sarlinpe changed the title Add missing COLMAP_CGAL_ENABLED [Bugfix] Add missing COLMAP_CGAL_ENABLED Sep 8, 2023
@sarlinpe sarlinpe changed the title [Bugfix] Add missing COLMAP_CGAL_ENABLED [Bugfix] Properly handle CGAL_ENABLED Sep 8, 2023
@ahojnnes
ahojnnes enabled auto-merge (squash) September 10, 2023 06:30
@ahojnnes
ahojnnes merged commit b752178 into colmap:main Sep 10, 2023
@sarlinpe
sarlinpe deleted the paul/add-cgal-enabled branch September 12, 2023 07:21
sarlinpe pushed a commit to sarlinpe/colmap that referenced this pull request Sep 13, 2023
* Add missing COLMAP_CGAL_ENABLED

* Fix build when CGAL_ENABLED=OFF

---------

Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.