Only apply sqlite vacuum command when elements are deleted from the database.#1414
Merged
ahojnnes merged 1 commit intoJan 31, 2022
colmap:devcolmap/colmap:devfrom
ferreram:database_vacuum_only_on_clearingferreram/colmap:database_vacuum_only_on_clearingCopy head branch name to clipboard
Merged
Only apply sqlite vacuum command when elements are deleted from the database.#1414ahojnnes merged 1 commit intocolmap:devcolmap/colmap:devfrom ferreram:database_vacuum_only_on_clearingferreram/colmap:database_vacuum_only_on_clearingCopy head branch name to clipboard
ahojnnes merged 1 commit into
colmap:devcolmap/colmap:devfrom
ferreram:database_vacuum_only_on_clearingferreram/colmap:database_vacuum_only_on_clearingCopy head branch name to clipboard
Conversation
Contributor
|
Setting mutable on fields is feels dangerous, as we are giving the false impression of not mutating the state of the object, which might be problematic when concurrently accessing it. I guess, we could ignore this problem in this specific case, as concurrent database access is anyway prohibited. Thanks for the fix. |
|
Hi! |
lucasthahn
pushed a commit
to tne-ai/colmap
that referenced
this pull request
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1413 . Vacuum command was applied whenever the close function is called leading to important delay whenever accessing the database. As the vacuum command is meant to decrease the size of db files by deleting allocated chunks of memory not used anymore, the PR only applies it when elements are deleted from the database.