Upgrade ActiveModelSerializers gem to 10.x, take 2 - #36686
#36686Merged
uponthesun merged 2 commits intoSep 10, 2020
stagingcode-dot-org/code-dot-org:stagingfrom
serializer-upgrade-fixcode-dot-org/code-dot-org:serializer-upgrade-fixCopy head branch name to clipboard
Merged
Upgrade ActiveModelSerializers gem to 10.x, take 2#36686uponthesun merged 2 commits intostagingcode-dot-org/code-dot-org:stagingfrom serializer-upgrade-fixcode-dot-org/code-dot-org:serializer-upgrade-fixCopy head branch name to clipboard
uponthesun merged 2 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
serializer-upgrade-fixcode-dot-org/code-dot-org:serializer-upgrade-fixCopy head branch name to clipboard
Conversation
added 2 commits
September 9, 2020 23:47
uponthesun
commented
Sep 10, 2020
|
|
||
| hidden = JSON.parse(response.body) | ||
| assert_equal [@custom_lesson_1.id.to_s], hidden | ||
| assert_equal [@custom_lesson_1.id], hidden |
Author
There was a problem hiding this comment.
The shape returned from this API for students is now technically different - It used to be ["123"] and now it's [123] - but I manually tested to confirm that it still works with the javascript code. It doesn't make a ton of sense why they were returned as strings to begin with.
davidsbailey
approved these changes
Sep 10, 2020
davidsbailey
left a comment
Member
There was a problem hiding this comment.
new code change looks good! Notes for additional context (please correct me if I have something wrong):
cforkish
approved these changes
Sep 10, 2020
cforkish
left a comment
Contributor
There was a problem hiding this comment.
wow, such a little issue caused such a big problem! thanks for tracking this down @uponthesun!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies #36560, which was reverted here #36676 because it broke the ability for teachers to hide lessons.
The only change on top of that is this commit: c0f7d1c which fixes the behavior for
ScriptLevelsController#hidden_stage_ids.Testing story
Manually tested hiding lessons on
/s/allthethingslocally as a Teacher, and viewing/s/allthethingsas a Student in that teacher's section and verifying that the lesson is correctly hidden.Reviewer Checklist: