Add unit test on ScriptLevelsController#hidden_stage_ids for teacher - #36681
#36681Merged
uponthesun merged 1 commit intoSep 10, 2020
stagingcode-dot-org/code-dot-org:stagingfrom
hidden-stage-ids-unit-testcode-dot-org/code-dot-org:hidden-stage-ids-unit-testCopy head branch name to clipboard
Merged
Add unit test on ScriptLevelsController#hidden_stage_ids for teacher#36681uponthesun merged 1 commit intostagingcode-dot-org/code-dot-org:stagingfrom hidden-stage-ids-unit-testcode-dot-org/code-dot-org:hidden-stage-ids-unit-testCopy head branch name to clipboard
uponthesun merged 1 commit into
stagingcode-dot-org/code-dot-org:stagingfrom
hidden-stage-ids-unit-testcode-dot-org/code-dot-org:hidden-stage-ids-unit-testCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing test. The shape of the response returned is different for teachers compared to students.
This was one of the things broken by: #36560
That PR has been reverted; I'm adding unit tests for the affected APIs, then I'll fix the behavior on that branch and make a new PR.
I think this is the only thing that broke in the two failing eyes tests (hiding lessons).