Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Code adapted for Python 3#14

Closed
eillarra wants to merge 3 commits into
cloudflare:mastercloudflare/python-cloudflare:masterfrom
eillarra:2to3Copy head branch name to clipboard
Closed

Code adapted for Python 3#14
eillarra wants to merge 3 commits into
cloudflare:mastercloudflare/python-cloudflare:masterfrom
eillarra:2to3Copy head branch name to clipboard

Conversation

@eillarra

@eillarra eillarra commented Oct 29, 2016

Copy link
Copy Markdown

Now using absolute_import from __future__ to mimic Python 3 behaviour: this is needed for relative imports (PEP 328).

Without this changes the package fails when using it with Python 3.* because the __init__ file raises an Exception when trying to:

from cloudflare import CloudFlare

In the process I have fixed some indentation problems with mixed tabs and spaces.

@eillarra eillarra changed the title Code adapted for Python 3. Code adapted for Python 3 Oct 29, 2016
Now using absolute_import from __future__ to mimic Python 3 behaviour: this is needed for relative imports (PEP 328).
+ fixed some indentation problems with mixed tabs and spaces.
@eillarra

eillarra commented Nov 2, 2016

Copy link
Copy Markdown
Author

I close this one because it seems @mahtin is working on parallel on Python 3 compatibility. Some of the changes are already on the repo, some other not, but this PR and #1 have conflicts now so it is better if we close them and wait until @mahtin finishes the migration to Python 3...

@eillarra eillarra closed this Nov 2, 2016
@eillarra eillarra mentioned this pull request Nov 2, 2016
@eillarra eillarra reopened this Nov 3, 2016
@eillarra

Copy link
Copy Markdown
Author

I close this one because @mahtin has worked on parallel on Python 3 compatibility.

@eillarra eillarra closed this Feb 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.