This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Python3ify#1
Closed
danni wants to merge 5 commits into
Closed
Python3ify#1danni wants to merge 5 commits into
danni wants to merge 5 commits into
Conversation
danni
commented
May 14, 2016
- Make python-cloudflare usable with Python3
- Fix the mixed tabs/space indenting (not py3k compatible)
- Since we're reindenting, bring it closer to PEP8
- Run pylint over the result, fix any remaining errors
added 5 commits
May 14, 2016 13:00
Since we're reindenting may as well fix pep8. Add __future__ statements to ensure identical behaviours on Python 2 and 3.
|
OK - this is very helpful and I'll get to this within a day or so. It is needed; however, I didn't have a python3 setup to test this when I posted. More latter. |
|
@mahtin when will the above diff's be approved? This module isn't working with Python 3.x |
|
Any news or should we consider this abandonware? |
|
Yup - all clean now - Python3 (all the way up to 3.8) is now supported. Plus Python2 support is now deprecated - even if it still works. Grab the latest at https://pypi.org/project/cloudflare/ via a pip install --upgrade cloudflare command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.