Make update_cursors run in a new CursorSystems::Update system set#25165
Open
mgi388 wants to merge 2 commits into
Open
Make update_cursors run in a new CursorSystems::Update system set#25165mgi388 wants to merge 2 commits into
mgi388 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
CursorIconinserts strictly before they are applied/updated.Solution
bevy_windowa laCursorIconso that call sites don't depend onbevy_winitspecifics for this ordering? In that way,bevy_winitwould import the system set frombevy_windowand itself become a "user" of the system set. One could imagine a futurebevy_sdlbackend would use the same system set frombevy_window. Might be fine as I've done it though?Testing
custom_cursor_imageexample.