Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix autocompletion for API arguments #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borisstoyanov merged 2 commits into from
Apr 25, 2023
Merged

Fix autocompletion for API arguments #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55edd00
Fix autocompletion for migrateSystemVms
nvazquez Apr 24, 2023
4975c03
Fix createNetwork associatednetworkid param autocompletion
nvazquez Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions 4 cli/completer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ func findAutocompleteAPI(arg *config.APIArg, apiFound *config.API, apiMap map[st
relatedNoun = "publicipaddresses"
case argName == "storageid":
relatedNoun = "storagepools"
case argName == "associatednetworkid":
relatedNoun = "networks"
default:
// Heuristic: autocomplete for the arg for which a list<Arg without id/ids>s API exists
// For example, for zoneid arg, listZones API exists
Expand Down Expand Up @@ -387,6 +389,8 @@ func (t *autoCompleter) Do(line []rune, pos int) (options [][]rune, offset int)

if apiFound.Name != "provisionCertificate" && autocompleteAPI.Name == "listHosts" {
autocompleteAPIArgs = append(autocompleteAPIArgs, "type=Routing")
} else if apiFound.Name == "migrateSystemVm" {
autocompleteAPI.Name = "listSystemVms"
}

spinner := t.Config.StartSpinner("fetching options, please wait...")
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.