Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix autocompletion for API arguments - #133

#133
Merged
borisstoyanov merged 2 commits into
apache:mainapache/cloudstack-cloudmonkey:mainfrom
nvazquez:fix-autocompleteCopy head branch name to clipboard
Apr 25, 2023
Merged

Fix autocompletion for API arguments#133
borisstoyanov merged 2 commits into
apache:mainapache/cloudstack-cloudmonkey:mainfrom
nvazquez:fix-autocompleteCopy head branch name to clipboard

Conversation

@nvazquez

@nvazquez nvazquez commented Apr 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #72 and #118

Tested:

$ ./bin/cmk 
Apache CloudStack 🐵 CloudMonkey 6.3.0
Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues

(labenv) 🐱 > migrate systemvm virtualmachineid=
4060725f-463e-4f59-b628-eed0e94e2bca (v-1-VM)       558bc1a6-e4ef-4e4c-b88a-8980fbb8bccd (s-2-VM)

...

(labenv) 🐱 > create network associatednetworkid=
ac6ba13c-220c-41b2-83bb-df7f5a2bfbf2 (test-net)     c00b4ea9-41d3-44c2-aad5-fa5555757cfc (L2)

@nvazquez nvazquez added this to the 6.3.0 milestone Apr 24, 2023
@nvazquez
nvazquez requested review from borisstoyanov and yadvr April 24, 2023 16:30
weizhouapache
weizhouapache approved these changes Apr 24, 2023
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm
@nvazquez can you upload the binary file for testing ? Thanks

@nvazquez

nvazquez commented Apr 24, 2023

Copy link
Copy Markdown
Contributor Author

Sure @weizhouapache - please find it here: https://drive.google.com/file/d/1VuI7yt3Ril44g5DiLhXsf4XqKq9cqMBv/view?usp=sharing

@weizhouapache

weizhouapache commented Apr 24, 2023

Copy link
Copy Markdown
Member

Sure @weizhouapache - please find it here: https://drive.google.com/file/d/1VuI7yt3Ril44g5DiLhXsf4XqKq9cqMBv/view?usp=sharing

@nvazquez
it is not executable. anyway, I have built the binary and tested it.

(localcloud) 🐱 > list publicipaddresses associatednetworkid=
324622ca-15bf-4878-8da0-21e5b656e592 (capc-cluster-kvm-network)                       a3bda23f-d266-4eef-bb31-547539912e27 (cks-cluster-via-terraform-network)              
cc0d8e91-b2c6-4447-a77d-413d82724ff7 (test)                                           cecbd9f8-f9dd-4e4f-903a-07ece1136a5f (capc-cluster-kvm-vpc-001) 

(localcloud) 🐱 > migrate systemvm virtualmachineid=
bf54db53-30b7-4e44-be9f-5ba87cfb95f2 (v-1-VM)            d99f93ed-38d9-4c47-a1b0-ae2a44132393 (s-2-VM)

borisstoyanov
borisstoyanov approved these changes Apr 25, 2023
View reviewed changes

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-04-25 at 15 41 44
LGTM

@borisstoyanov
borisstoyanov merged commit 74698cd into apache:main Apr 25, 2023
@borisstoyanov borisstoyanov mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@borisstoyanov borisstoyanov borisstoyanov approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.3.0

Development

Successfully merging this pull request may close these issues.

migrate systemvm virtualmachine= lists guest vms instead of systemvms

4 participants

@nvazquez @weizhouapache @yadvr @borisstoyanov
Morty Proxy This is a proxified and sanitized view of the page, visit original site.