UI improvements #9773
Conversation
… than English (apache#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #9773 +/- ##
============================================
- Coverage 16.14% 16.00% -0.15%
- Complexity 12972 13065 +93
============================================
Files 5639 5644 +5
Lines 494299 494915 +616
Branches 59909 59960 +51
============================================
- Hits 79789 79195 -594
- Misses 405685 406883 +1198
- Partials 8825 8837 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@blueorangutan package |
|
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11289 |
|
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@abh1sar , given that there are DB changes as well, I don't think UI tests will be enought, do you? |
@DaanHoogland You are right. For the rest of the items, ui testing is enough. P.S I have added db changes to schema-41900to42000 for now. Will move it to schema-42000-42010 once CloudStack version changes to 4.20.1. Will keep this PR in draft until then. |
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql
Outdated
Show resolved
Hide resolved
Pearl1594
left a comment
There was a problem hiding this comment.
clgtm, just a few queries.
| return ((['Running'].includes(record.state) && record.hypervisor !== 'LXC') || | ||
| (['Stopped'].includes(record.state) && !['KVM', 'LXC'].includes(record.hypervisor))) | ||
| show: (record, store) => { | ||
| return (record.hypervisor !== 'KVM') || |
There was a problem hiding this comment.
I tried to keep the UI conditions same as the service layer. Please see hostSupportsSnapsthotForVolume().
But I'm ok if we don't want to allow snapshot creation from UI for destroyed VMs.
| record.hypervisor === 'KVM' && record.vmstate !== 'Running') | ||
| return record.state === 'Ready' && | ||
| (record.hypervisor !== 'KVM' || | ||
| ['Stopped', 'Destroyed'].includes(record.vmstate) || |
There was a problem hiding this comment.
same here, why destroyed state ?
There was a problem hiding this comment.
Before this change, the button would be shown for all states part from 'Running'.
Now it will only be shown for 'Stopped' or 'Destroyed' states
| record.hypervisor === 'KVM' && record.vmstate !== 'Running') | ||
| return record.state === 'Ready' && | ||
| (record.hypervisor !== 'KVM' || | ||
| (['Stopped', 'Destroyed'].includes(record.vmstate)) || |
|
[SF] Trillian Build Failed (tid-11647) |
|
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12070 |
|
@blueorangutan test |
|
@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-12106)
|
|
Test failures are not related to the change, which is mostly ui. |
andrijapanicsb
left a comment
There was a problem hiding this comment.
LGTM, based on 4-eyes review of the UI (Simulator)
server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
Outdated
Show resolved
Hide resolved
|
(committed just the changed message/language that @abh1sar probably didn't see - hope that is OK) |
|
@blueorangutan package |
|
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12344 |
Failures seen in apache#10006 (comment) and others. With apache#9773, the response of listManagementServers API has been changed. serviceip has been renamed to ipaddress. THis was causing not all MS getting restarted and purge b/g task not being able to run. The code handling API response in the test has been updated. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Failures seen in apache#10006 (comment) and others. With apache#9773, the response of listManagementServers API has been changed. serviceip has been renamed to ipaddress. THis was causing not all MS getting restarted and purge b/g task not being able to run. The code handling API response in the test has been updated. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Failures seen in #10006 (comment) and others. With #9773, the response of listManagementServers API has been changed. serviceip has been renamed to ipaddress. This was causing not all MS getting restarted and purge b/g task not being able to run. The code handling API response in the test has been updated. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
* Show Usage Server configuration in a separate pane * UI: Option to attach volume to an instance during create volume * Show service ip in management server details tab * change Schedule Snapshots to Recurring Snapshots * Change the hypervisor order so that kvm, vmware, xenserver show up first * Remove extra space in hypervisor names in config.java * Fix `updateTemplatePermission` when the UI is set to a language other than English (apache#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br> * Autofill vcenter details in add cluster form * UI: condition to display create vm-vol-snapshots to same as create vol-snapshots * Fix alignment on wrapping in global settings tabs * rename Autofill vCenter credentials to Autofill vCenter credentials from Zone * Rename Service Ip to Ip Address in management server response * Change description of kvm.snapshot.enabled to say that it applies to volume snapshots * Return error when kvm vm snapshot is taken withoutsnapshot memory * Minor naming changes and grammar * Fix tooltip for attach volume to instance button * Show Usage Server configuration in a separate pane * UI: Option to attach volume to an instance during create volume * Show service ip in management server details tab * change Schedule Snapshots to Recurring Snapshots * Change the hypervisor order so that kvm, vmware, xenserver show up first * Remove extra space in hypervisor names in config.java * Autofill vcenter details in add cluster form * UI: condition to display create vm-vol-snapshots to same as create vol-snapshots * Fix alignment on wrapping in global settings tabs * rename Autofill vCenter credentials to Autofill vCenter credentials from Zone * Rename Service Ip to Ip Address in management server response * Change description of kvm.snapshot.enabled to say that it applies to volume snapshots * Return error when kvm vm snapshot is taken withoutsnapshot memory * Minor naming changes and grammar * Fix tooltip for attach volume to instance button * Show Usage Server configuration in a separate pane * UI: Option to attach volume to an instance during create volume * Show service ip in management server details tab * change Schedule Snapshots to Recurring Snapshots * Change the hypervisor order so that kvm, vmware, xenserver show up first * Remove extra space in hypervisor names in config.java * Autofill vcenter details in add cluster form * UI: condition to display create vm-vol-snapshots to same as create vol-snapshots * Fix alignment on wrapping in global settings tabs * rename Autofill vCenter credentials to Autofill vCenter credentials from Zone * Rename Service Ip to Ip Address in management server response * Change description of kvm.snapshot.enabled to say that it applies to volume snapshots * Return error when kvm vm snapshot is taken withoutsnapshot memory * Minor naming changes and grammar * Fix tooltip for attach volume to instance button * UI: Option to attach volume to an instance during create volume * UI: condition to display create vm-vol-snapshots to same as create vol-snapshots * moved db changes from 41900to42000 to 42000to42010 * Update group_id in already present usage configuration settings * remove "schedule" from message in create Recurring Snapshots form * Update server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --------- Co-authored-by: Daan Hoogland <daan@onecht.net> Co-authored-by: Lucas Martins <56271185+lucas-a-martins@users.noreply.github.com> Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br> Co-authored-by: Boris Stoyanov - a.k.a Bobby <bss.stoyanov@gmail.com> Co-authored-by: Andrija Panic <45762285+andrijapanicsb@users.noreply.github.com>
…e#10501) Failures seen in apache#10006 (comment) and others. With apache#9773, the response of listManagementServers API has been changed. serviceip has been renamed to ipaddress. This was causing not all MS getting restarted and purge b/g task not being able to run. The code handling API response in the test has been updated. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Description
This PR does multiple UI improvements
Items 1,3,4,5,6 are UI only changes, and can be tested with just the UI.
Doc PR : apache/cloudstack-documentation#448
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?