Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: fix failure in test_06_purge_expunged_vm_background_task#10501

Merged
shwstppr merged 1 commit intoapache:4.20apache/cloudstack:4.20from
shapeblue:fix-purgebg-testshapeblue/cloudstack:fix-purgebg-testCopy head branch name to clipboard
Mar 6, 2025
Merged

test: fix failure in test_06_purge_expunged_vm_background_task#10501
shwstppr merged 1 commit intoapache:4.20apache/cloudstack:4.20from
shapeblue:fix-purgebg-testshapeblue/cloudstack:fix-purgebg-testCopy head branch name to clipboard

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Mar 5, 2025

Description

Failures seen in
#10006 (comment) and others.

With #9773, the response of listManagementServers API has been changed. serviceip has been renamed to ipaddress. THis was causing not all MS getting restarted and purge b/g task not being able to run. The code handling API response in the test has been updated.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Mar 5, 2025
@shwstppr shwstppr requested a review from Pearl1594 March 5, 2025 08:00
@shwstppr shwstppr added this to the 4.20.1 milestone Mar 5, 2025
@shwstppr shwstppr requested a review from abh1sar March 5, 2025 08:01
@shwstppr
test: fix failure in test_06_purge_expunged_vm_background_task
36c8061 
Failures seen in
apache#10006 (comment)
and others.

With apache#9773, the response of
listManagementServers API has been changed. serviceip has been renamed
to ipaddress. THis was causing not all MS getting restarted and purge
b/g task not being able to run. The code handling API response in the
test has been updated.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Mar 5, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 5, 2025

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.00%. Comparing base (80b5d5c) to head (36c8061).
Report is 3 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10501   +/-   ##
=========================================
  Coverage     16.00%   16.00%           
- Complexity    13104    13105    +1     
=========================================
  Files          5651     5651           
  Lines        495862   495862           
  Branches      60043    60043           
=========================================
+ Hits          79367    79376    +9     
+ Misses       407635   407622   -13     
- Partials       8860     8864    +4
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

blueorangutan commented Mar 5, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12660

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Mar 5, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Mar 5, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

bernardodemarco
bernardodemarco approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Pearl1594
Pearl1594 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@blueorangutan
Copy link

blueorangutan commented Mar 6, 2025

[SF] Trillian test result (tid-12576)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53119 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10501-t12576-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@shwstppr
Copy link
Contributor Author

shwstppr commented Mar 6, 2025

Test looks good now

[SF] Trillian test result (tid-12576) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53119 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10501-t12576-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File

@shwstppr shwstppr merged commit 35a7438 into apache:4.20 Mar 6, 2025
25 of 26 checks passed
@shwstppr shwstppr deleted the fix-purgebg-test branch March 6, 2025 03:55
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
@weizhouapache weizhouapache mentioned this pull request May 19, 2025
Merged
14 tasks
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@shwstppr @dhslove
test: fix failure in test_06_purge_expunged_vm_background_task (apach…
886d8f8 
…e#10501)

Failures seen in apache#10006 (comment) and others.

With apache#9773, the response of
listManagementServers API has been changed. serviceip has been renamed
to ipaddress. This was causing not all MS getting restarted and purge
b/g task not being able to run. The code handling API response in the
test has been updated.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

+1 more reviewer

@abh1sar abh1sar abh1sar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

7 participants

@shwstppr @blueorangutan @DaanHoogland @yadvr @Pearl1594 @abh1sar @bernardodemarco
Morty Proxy This is a proxified and sanitized view of the page, visit original site.