Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Adding zone name to physicalnetworkresponse#4510

Merged
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
shapeblue:add-zone-phy-netshapeblue/cloudstack:add-zone-phy-netCopy head branch name to clipboard
Dec 2, 2020
Merged

Adding zone name to physicalnetworkresponse#4510
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
shapeblue:add-zone-phy-netshapeblue/cloudstack:add-zone-phy-netCopy head branch name to clipboard

Conversation

@davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Dec 1, 2020

Description

Adding zone name to physicalnetworkresponse which looks better on the UI

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Before :

Screenshot from 2020-12-01 12-19-12

After :

Screenshot from 2020-12-01 12-18-23

How Has This Been Tested?

(localhost) 🐱 > list physicalnetworks 
{
  "count": 1,
  "physicalnetwork": [
    {
      "broadcastdomainrange": "ZONE",
      "id": "580b516c-f1fa-4fc4-949c-42381a394287",
      "isolationmethods": "VLAN",
      "name": "Sandbox-pnet",
      "state": "Enabled",
      "vlan": "100-200",
      "zoneid": "ee54cb21-c2e2-4757-bb4a-a2e16a4c2516",
      "zonename": "Sandbox-simulator"
    }
  ]
}

@davidjumani
Copy link
Contributor Author

davidjumani commented Dec 1, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Dec 1, 2020

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Dec 1, 2020

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2451

@yadvr yadvr added this to the 4.15.0.0 milestone Dec 1, 2020
@yadvr
Copy link
Member

yadvr commented Dec 1, 2020

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Dec 1, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Dec 1, 2020

Trillian test result (tid-3294)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31636 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4510-t3294-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

GabrielBrascher
GabrielBrascher approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidjumani davidjumani mentioned this pull request Dec 1, 2020
Merged
@yadvr yadvr merged commit 93ff156 into apache:master Dec 2, 2020
qrry pushed a commit to qrry/cloudstack that referenced this pull request Dec 4, 2020
@qrrylau
Merge branch 'master' into dev
71956b7 
* master: (25 commits)
  integration test: skip vlan of public ip range in get_free_vlan
  vpc vr: plugin nics by this order: public/private/guest
  vpc vr: fix Conflicting device id on private gw nic
  Adding zone name to physicalnetworkresponse (apache#4510)
  Disallowing udp for lb rules for haproxy (apache#4501)
  Make global setting non-dynamic (apache#4505)
  Adding cpuallocated percentage and value to host and hostsformigrationresponse (apache#4499)
  kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs (apache#4496)
  fix failures with test_multiple_nic_support.py (apache#4495)
  Fix hosts for migration count (apache#4500)
  sql: Fix Zones are returned in a random order (apache#3934) (apache#4494)
  integration test: update steps
  integration test: add private gateway in test
  integration test: verify public nics state
  bugfix apache#9 vpc vr: Add PREROUTING rule for vm with static nat to multiple private gateways
  bugfix apache#8 vpc: add rule for traffic between vm and private gateway
  bugfix apache#7 vpc vr: allow servers in private gateway to reach internet via the VPC VR if it is gateway
  bugfix apache#6 vpc vr: Add iptables rules for ACL of private gateway
  Revert "Fix Policy Based Routing for private gateway static routes (apache#3604)"
  Revert "Add private gateway IP to router initialization config"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

type:enhancement

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@davidjumani @blueorangutan @yadvr @GabrielBrascher
Morty Proxy This is a proxified and sanitized view of the page, visit original site.