Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Make global setting "secstorage.max.migrate.sessions" non-dynamic#4505

Merged
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
shapeblue:fix-GSshapeblue/cloudstack:fix-GSCopy head branch name to clipboard
Dec 1, 2020
Merged

Make global setting "secstorage.max.migrate.sessions" non-dynamic#4505
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
shapeblue:fix-GSshapeblue/cloudstack:fix-GSCopy head branch name to clipboard

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Nov 30, 2020 •
edited
Loading

Description

This PR:

  • makes the global setting "secstorage.max.migrate.sessions" non dynamic - as it requires a restart to take effect
  • removes an hard-coded value being passed for CopyCommand: This is done so that concurrency can be achieved at the SSVM end. With executeInsequence being set to 'true' while from the MS end it attempts to send multiple copy requests for data migration, at the agent end, it still handles the requests sequentially. Hence, to mitigate this behavior, change has been made to fallback on what is configured on the GS for executing in sequence.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Verified the behavior of global setting by changing its value and it taking effect post restart of MS

@Pearl1594 Pearl1594 added this to the 4.15.0.0 milestone Nov 30, 2020
@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Nov 30, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 30, 2020

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Nov 30, 2020

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2442

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Nov 30, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 30, 2020

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Nov 30, 2020

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2445

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Nov 30, 2020

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 30, 2020

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr yadvr requested a review from PaulAngus November 30, 2020 10:53
GabrielBrascher
GabrielBrascher approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link

blueorangutan commented Nov 30, 2020

Trillian test result (tid-3286)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37474 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4505-t3286-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_upgrade_kubernetes_cluster Failure 267.26 test_kubernetes_clusters.py

@sureshanaparti sureshanaparti changed the title Make global setting non-dynamic Make global setting "secstorage.max.migrate.sessions" non-dynamic Dec 1, 2020
@yadvr yadvr merged commit e4a504b into apache:master Dec 1, 2020
qrry pushed a commit to qrry/cloudstack that referenced this pull request Dec 4, 2020
@qrrylau
Merge branch 'master' into dev
71956b7 
* master: (25 commits)
  integration test: skip vlan of public ip range in get_free_vlan
  vpc vr: plugin nics by this order: public/private/guest
  vpc vr: fix Conflicting device id on private gw nic
  Adding zone name to physicalnetworkresponse (apache#4510)
  Disallowing udp for lb rules for haproxy (apache#4501)
  Make global setting non-dynamic (apache#4505)
  Adding cpuallocated percentage and value to host and hostsformigrationresponse (apache#4499)
  kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs (apache#4496)
  fix failures with test_multiple_nic_support.py (apache#4495)
  Fix hosts for migration count (apache#4500)
  sql: Fix Zones are returned in a random order (apache#3934) (apache#4494)
  integration test: update steps
  integration test: add private gateway in test
  integration test: verify public nics state
  bugfix apache#9 vpc vr: Add PREROUTING rule for vm with static nat to multiple private gateways
  bugfix apache#8 vpc: add rule for traffic between vm and private gateway
  bugfix apache#7 vpc vr: allow servers in private gateway to reach internet via the VPC VR if it is gateway
  bugfix apache#6 vpc vr: Add iptables rules for ACL of private gateway
  Revert "Fix Policy Based Routing for private gateway static routes (apache#3604)"
  Revert "Add private gateway IP to router initialization config"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

@PaulAngus PaulAngus Awaiting requested review from PaulAngus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Pearl1594 @blueorangutan @yadvr @DaanHoogland @GabrielBrascher
Morty Proxy This is a proxified and sanitized view of the page, visit original site.