Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix failures with test_multiple_nic_support.py#4495

Merged
yadvr merged 1 commit intoapache:4.14apache/cloudstack:4.14from
ustcweizhou:4.14-fix-test-multiple-nicustcweizhou/cloudstack:4.14-fix-test-multiple-nicCopy head branch name to clipboard
Nov 30, 2020
Merged

fix failures with test_multiple_nic_support.py#4495
yadvr merged 1 commit intoapache:4.14apache/cloudstack:4.14from
ustcweizhou:4.14-fix-test-multiple-nicustcweizhou/cloudstack:4.14-fix-test-multiple-nicCopy head branch name to clipboard

Conversation

@ustcweizhou
Copy link
Contributor

@ustcweizhou ustcweizhou commented Nov 23, 2020

Description

This PR fixes a failure with integration test test_multiple_nic_support.py

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

DaanHoogland
DaanHoogland approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merely skipping when the right conditions aren't met. lgtm

@DaanHoogland DaanHoogland added this to the 4.14.1.0 milestone Nov 24, 2020
@yadvr
Copy link
Member

yadvr commented Nov 24, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 24, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Nov 24, 2020

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2430

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 24, 2020

only change is in a component test so running smoke tests is not relevant. @borisstoyanov @vladimirpetrov care to do the honours?

@yadvr
Copy link
Member

yadvr commented Nov 27, 2020

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 27, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Nov 27, 2020

Trillian test result (tid-3273)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30833 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4495-t3273-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 29, 2020

@blueorangutan test centos7 kvm-centos7 keepEnv

@blueorangutan
Copy link

blueorangutan commented Nov 29, 2020

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Nov 30, 2020

Trillian test result (tid-3284)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32635 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4495-t3284-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_upgrade_kubernetes_cluster Failure 243.84 test_kubernetes_clusters.py

@yadvr yadvr merged commit e8ee8e9 into apache:4.14 Nov 30, 2020
qrry pushed a commit to qrry/cloudstack that referenced this pull request Dec 4, 2020
@qrrylau
Merge branch 'master' into dev
71956b7 
* master: (25 commits)
  integration test: skip vlan of public ip range in get_free_vlan
  vpc vr: plugin nics by this order: public/private/guest
  vpc vr: fix Conflicting device id on private gw nic
  Adding zone name to physicalnetworkresponse (apache#4510)
  Disallowing udp for lb rules for haproxy (apache#4501)
  Make global setting non-dynamic (apache#4505)
  Adding cpuallocated percentage and value to host and hostsformigrationresponse (apache#4499)
  kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs (apache#4496)
  fix failures with test_multiple_nic_support.py (apache#4495)
  Fix hosts for migration count (apache#4500)
  sql: Fix Zones are returned in a random order (apache#3934) (apache#4494)
  integration test: update steps
  integration test: add private gateway in test
  integration test: verify public nics state
  bugfix apache#9 vpc vr: Add PREROUTING rule for vm with static nat to multiple private gateways
  bugfix apache#8 vpc: add rule for traffic between vm and private gateway
  bugfix apache#7 vpc vr: allow servers in private gateway to reach internet via the VPC VR if it is gateway
  bugfix apache#6 vpc vr: Add iptables rules for ACL of private gateway
  Revert "Fix Policy Based Routing for private gateway static routes (apache#3604)"
  Revert "Add private gateway IP to router initialization config"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:integration-test Severity:Trivial type:bug

Projects

None yet

Milestone

4.14.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ustcweizhou @yadvr @blueorangutan @DaanHoogland
Morty Proxy This is a proxified and sanitized view of the page, visit original site.