Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(webpack): remove usage of __dirname from the config.#3422

Merged
hansl merged 1 commit into
angular:masterangular/angular-cli:masterfrom
hansl:dirnamehansl/angular-cli:dirnameCopy head branch name to clipboard
Dec 6, 2016
Merged

fix(webpack): remove usage of __dirname from the config.#3422
hansl merged 1 commit into
angular:masterangular/angular-cli:masterfrom
hansl:dirnamehansl/angular-cli:dirnameCopy head branch name to clipboard

Conversation

@hansl

@hansl hansl commented Dec 6, 2016

Copy link
Copy Markdown
Contributor

Fixes #3419

resolve: {
extensions: ['.ts', '.js'],
modules: [nodeModules]
modules: [nodeModules],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the project does not include trailing comma.

@hansl hansl merged commit 8597786 into angular:master Dec 6, 2016
@hansl hansl deleted the dirname branch December 6, 2016 18:35
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correctly resolve WebPack loaders within npm linked modules

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.