Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Correctly resolve WebPack loaders within npm linked modules #3419

Copy link
Copy link
@garkbit

Description

@garkbit
Issue body actions

OS?

OSX Sierra

Versions.

angular-cli: 1.0.0-beta.18
node: 6.9.1
os: darwin x64

Repro steps.

Install NPM linked package that uses a WebPack loader. Loader cannot be resolved.

The log given by the failure.

Module not found: Error: Can't resolve 'style' in '...'

Mention any other details that might be useful.

Merge #2291 was incomplete, in that it does not fully address the issue raised in #1875. It fixes module resolution, but not loader resolution. The following needs to be added to the object returned from getWebpackCommonConfig() in webpack-build-common.ts in order to match current module resolution strategy:

resolveLoader: {
  modules: [path.resolve(projectRoot, 'node_modules')]
}

Also, I would submit a pull request, but the the corporate overhead of getting a CLA in place are prohibitive.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgenteffort1: easy (hours)type: bug/fix

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.