docs: small changes to contibting.md - #38137
#38137docs: small changes to contibting.md#38137ajitsinghkaler wants to merge 1 commit intoangular:masterangular/angular:masterfrom ajitsinghkaler:contributing.mdajitsinghkaler/angular:contributing.mdCopy head branch name to clipboard
Conversation
maximum length of commit message line can be 120 characters intead of 100. Fixes lines should come before BREAKING CHANGE blocks. Otherwise they become part of the breaking change notice.
gkalpak
left a comment
There was a problem hiding this comment.
Thx, @ajitsinghkaler, for taking the time to send in a fix 馃挴
However, I am afraid the changes are not valid/desirable (see my comments).
| The `footer` is optional. | ||
|
|
||
| Any line of the commit message cannot be longer than 100 characters. | ||
| Any line of the commit message cannot be longer than 120 characters. |
There was a problem hiding this comment.
Actually, we want each line to have max. 100 chars. The current limit of 120 is supposed to be a "temporary" work-around that we seem we to have forgotten to revert: bf57df3
Maybe you could try reverting that to 100 and see if CI is indeed happy.
| <breaking change description + migration instructions> | ||
| <BLANK LINE> | ||
| <BLANK LINE> | ||
| Fixes #<issue number> |
There was a problem hiding this comment.
You are right that we used to require the issue/PR references to be above the breaking change notice, but this has changed recently. So, putting the Fixes ... section below the BREAKING CHANGE section here was intentional. See the discussion in #37951 (comment).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
maximum length of commit message line can be 120 characters intead of 100.
Fixes lines should come before BREAKING CHANGE blocks. Otherwise they become
part of the breaking change notice.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information