Create shared .gitconfig and .gitmessage with commit message template - #37951
#37951Closed
IgorMinar wants to merge 11 commits into
angular:masterangular/angular:masterfrom
IgorMinar:build/shared-.gitconfigIgorMinar/angular:build/shared-.gitconfigCopy head branch name to clipboard
Closed
Create shared .gitconfig and .gitmessage with commit message template#37951IgorMinar wants to merge 11 commits intoangular:masterangular/angular:masterfrom IgorMinar:build/shared-.gitconfigIgorMinar/angular:build/shared-.gitconfigCopy head branch name to clipboard
IgorMinar wants to merge 11 commits into
angular:masterangular/angular:masterfrom
IgorMinar:build/shared-.gitconfigIgorMinar/angular:build/shared-.gitconfigCopy head branch name to clipboard
Conversation
IgorMinar
requested review from
gkalpak,
jelbourn,
petebacondarwin and
pkozlowski-opensource
July 7, 2020 02:08
IgorMinar
force-pushed
the
build/shared-.gitconfig
branch
3 times, most recently
from
July 7, 2020 02:13
2fb533b to
3fafcc6
Compare
petebacondarwin
suggested changes
Jul 7, 2020
pkozlowski-opensource
left a comment
Member
There was a problem hiding this comment.
@IgorMinar I like the idea a lot! Agree with the @petebacondarwin remarks, though, so adding the cleanup label.
gkalpak
reviewed
Jul 7, 2020
Member
There was a problem hiding this comment.
I love the idea (although I couldn't get it to work for me - it may be a Windows thing 😅 Typical PEBCAK situation).
The second commit message makes it sound as if .gitmessage is a special file in git (similar to .gitignore or .gitattributes), but afaict that is not the case. Might be worth rephrasing for clarity.
Contributor
Author
|
@gkalpak which part didn't work on windows? The shared gitconfig or the template? Both should work on windows as far as I know. |
Member
|
I couldn't get the message template to work 😞 |
Member
|
NVM, I tried it again and now it worked fine. Not sure what I did wrong before. Sorry for the noise 😇 |
petebacondarwin
approved these changes
Jul 7, 2020
IgorMinar
force-pushed
the
build/shared-.gitconfig
branch
3 times, most recently
from
July 7, 2020 20:17
602685e to
8b44382
Compare
Contributor
Author
|
I pushed a bunch more changes. I linked the template to the commit message docs on github and updated them so that the github version is a strict superset of the version in the template that is a bit more succinct. |
IgorMinar
force-pushed
the
build/shared-.gitconfig
branch
from
July 7, 2020 20:22
8b44382 to
0d08568
Compare
gkalpak
reviewed
Jul 7, 2020
Contributor
|
Adding @aikidave for contributing guide changes |
jelbourn
reviewed
Jul 7, 2020
aikithoughts
approved these changes
Jul 10, 2020
aikithoughts
left a comment
There was a problem hiding this comment.
LGTM!
Reviewed-for: global-docs-approvers
…stent git config This file is inert unless it's explicitly included into the local git config via: ``` git config --add include.path '../.ng-dev/gitconfig' ``` Calling that command will append the following into `.git/config` of the current git workspace (i.e. $GIT_DIR, typically `angular/.git/config`): ``` [include] path = ../.ng-dev/gitconfig ``` I'm intentionally keeping the config inert for now until we prove that this is a good idea. Eventually we could roll this change out to all the contributors via an npm post-install script.
Git provides a way to create a commit message template via the `.gitmessage` file. Introduce an Angular-specific .gitmessage template based on the original Commit Message Guidelines. https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines If this template workflow is proven in practice, we can move the commit message guidelines into the .gitmessage file to prevent duplication of the content. This change is a follow up on angular#37949 and is inspired by info found in the following blog post: https://thoughtbot.com/blog/better-commit-messages-with-a-gitmessage-template
This doc is very old and rusty. I'm reformatting it to follow the one-setence-per-line rule. I also updated a few sections, since they were either poorly written or obsolete.
IgorMinar
force-pushed
the
build/shared-.gitconfig
branch
from
July 10, 2020 21:18
7a04f8f to
74fea3a
Compare
atscott
pushed a commit
that referenced
this pull request
Jul 13, 2020
…stent git config (#37951) This file is inert unless it's explicitly included into the local git config via: ``` git config --add include.path '../.ng-dev/gitconfig' ``` Calling that command will append the following into `.git/config` of the current git workspace (i.e. $GIT_DIR, typically `angular/.git/config`): ``` [include] path = ../.ng-dev/gitconfig ``` I'm intentionally keeping the config inert for now until we prove that this is a good idea. Eventually we could roll this change out to all the contributors via an npm post-install script. PR Close #37951
atscott
pushed a commit
that referenced
this pull request
Jul 13, 2020
Git provides a way to create a commit message template via the `.gitmessage` file. Introduce an Angular-specific .gitmessage template based on the original Commit Message Guidelines. https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines If this template workflow is proven in practice, we can move the commit message guidelines into the .gitmessage file to prevent duplication of the content. This change is a follow up on #37949 and is inspired by info found in the following blog post: https://thoughtbot.com/blog/better-commit-messages-with-a-gitmessage-template PR Close #37951
atscott
pushed a commit
that referenced
this pull request
Jul 13, 2020
This doc is very old and rusty. I'm reformatting it to follow the one-setence-per-line rule. I also updated a few sections, since they were either poorly written or obsolete. PR Close #37951
atscott
pushed a commit
that referenced
this pull request
Jul 13, 2020
Git provides a way to create a commit message template via the `.gitmessage` file. Introduce an Angular-specific .gitmessage template based on the original Commit Message Guidelines. https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines If this template workflow is proven in practice, we can move the commit message guidelines into the .gitmessage file to prevent duplication of the content. This change is a follow up on #37949 and is inspired by info found in the following blog post: https://thoughtbot.com/blog/better-commit-messages-with-a-gitmessage-template PR Close #37951
atscott
pushed a commit
that referenced
this pull request
Jul 13, 2020
This doc is very old and rusty. I'm reformatting it to follow the one-setence-per-line rule. I also updated a few sections, since they were either poorly written or obsolete. PR Close #37951
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…stent git config (angular#37951) This file is inert unless it's explicitly included into the local git config via: ``` git config --add include.path '../.ng-dev/gitconfig' ``` Calling that command will append the following into `.git/config` of the current git workspace (i.e. $GIT_DIR, typically `angular/.git/config`): ``` [include] path = ../.ng-dev/gitconfig ``` I'm intentionally keeping the config inert for now until we prove that this is a good idea. Eventually we could roll this change out to all the contributors via an npm post-install script. PR Close angular#37951
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
Git provides a way to create a commit message template via the `.gitmessage` file. Introduce an Angular-specific .gitmessage template based on the original Commit Message Guidelines. https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines If this template workflow is proven in practice, we can move the commit message guidelines into the .gitmessage file to prevent duplication of the content. This change is a follow up on angular#37949 and is inspired by info found in the following blog post: https://thoughtbot.com/blog/better-commit-messages-with-a-gitmessage-template PR Close angular#37951
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
This doc is very old and rusty. I'm reformatting it to follow the one-setence-per-line rule. I also updated a few sections, since they were either poorly written or obsolete. PR Close angular#37951
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for info.