This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Allow Terms Collection Params to be Filtered - #1882
#1882Merged
danielbachhuber merged 2 commits intoJan 4, 2016
developWP-API/WP-API:developfrom
fix-terms-pagination-headersWP-API/WP-API:fix-terms-pagination-headersCopy head branch name to clipboard
Merged
Allow Terms Collection Params to be Filtered#1882danielbachhuber merged 2 commits intodevelopWP-API/WP-API:developfrom fix-terms-pagination-headersWP-API/WP-API:fix-terms-pagination-headersCopy head branch name to clipboard
danielbachhuber merged 2 commits into
developWP-API/WP-API:developfrom
fix-terms-pagination-headersWP-API/WP-API:fix-terms-pagination-headersCopy head branch name to clipboard
Conversation
Member
Author
Member
There was a problem hiding this comment.
I don't have a strong preference either way, but renaming would make sense to me.
danielbachhuber
added a commit
that referenced
this pull request
Jan 4, 2016
Allow Terms Collection Params to be Filtered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a filter for the
prepared_argsbefore passing them toget_terms()(matching behavior to the Posts and Users collections), and then adjusting the pagination headers so that theprepared_argsare used instead of only the Request params.See #1878