This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Merged
Adjust Posts Pagination Headers for filter Params#1878
filter Params#1878Conversation
Member
Author
|
@WP-API/amigos #reviewmerge |
Member
Author
|
Even though it looks like only the Posts endpoints use the |
joehoyle
added a commit
that referenced
this pull request
Dec 21, 2015
Adjust Posts Pagination Headers for `filter` Params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
posts_per_pageandpagedvalues from$query_argsinstead of only from the shortened Request params when calculating theX-WP-TotalPagesheader as well as theprevandnextlink headers. This prevents incorrect headers when either thefilter[posts_per_page]orfilter[paged]request params are used, as well as hooks into therest_post_queryfilter.Fixes #1876