Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix ForEach-Progress snippet template#5122

Merged
andyleejordan merged 3 commits into
PowerShell:mainPowerShell/vscode-powershell:mainfrom
Cydroz:issue/5086-improve-progress-snippetCydroz/vscode-powershell:issue/5086-improve-progress-snippetCopy head branch name to clipboard
Jan 10, 2025
Merged

Fix ForEach-Progress snippet template#5122
andyleejordan merged 3 commits into
PowerShell:mainPowerShell/vscode-powershell:mainfrom
Cydroz:issue/5086-improve-progress-snippetCydroz/vscode-powershell:issue/5086-improve-progress-snippetCopy head branch name to clipboard

Conversation

@Cydroz

@Cydroz Cydroz commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

PR Summary

Concerns issue #5086 . PR #5087 Only fixes the validity of the snippet JSON syntax, and not the template itself.
This PR attempts to rectify the actual snippet into something more usable.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • (🚫NA) PR has tests
  • This PR is ready to merge and is not work in progress

@Cydroz Cydroz requested a review from a team as a code owner January 6, 2025 12:52

@andyleejordan andyleejordan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andyleejordan andyleejordan added the Issue-Enhancement A feature request (enhancement). label Jan 8, 2025
@andyleejordan andyleejordan enabled auto-merge (squash) January 8, 2025 18:55
@andyleejordan andyleejordan merged commit 0c5f2f8 into PowerShell:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Enhancement A feature request (enhancement).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.