Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix #5086 - Invalid JSON in the snippets file#5087

Merged
andyleejordan merged 9 commits into
PowerShell:mainPowerShell/vscode-powershell:mainfrom
o-l-a-v:fix-snippet-json-fileo-l-a-v/PowerShell--vscode-powershell:fix-snippet-json-fileCopy head branch name to clipboard
Nov 13, 2024
Merged

Fix #5086 - Invalid JSON in the snippets file#5087
andyleejordan merged 9 commits into
PowerShell:mainPowerShell/vscode-powershell:mainfrom
o-l-a-v:fix-snippet-json-fileo-l-a-v/PowerShell--vscode-powershell:fix-snippet-json-fileCopy head branch name to clipboard

Conversation

@o-l-a-v

@o-l-a-v o-l-a-v commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

PR Summary

Closes #5086

  • Fix invalid JSON file for snippets.
  • Added test suggestion for testing that the project only contains valid JSON files.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@o-l-a-v o-l-a-v requested a review from a team as a code owner November 8, 2024 13:57

@andyleejordan andyleejordan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

Comment thread .github/workflows/ci-test.yml
Comment thread .github/workflows/ci-test.yml Outdated
Comment thread .github/workflows/ci-test.yml Outdated
Comment thread tools/testValidJson.ps1 Outdated
Comment thread tools/testValidJson.ps1 Outdated
o-l-a-v and others added 3 commits November 13, 2024 19:16
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Comment thread tools/testValidJson.ps1 Outdated
@andyleejordan andyleejordan added this pull request to the merge queue Nov 13, 2024
@andyleejordan

Copy link
Copy Markdown
Member

Well that was annoying. A transitive dependency updated (I think the SDK does this when it runs in CI?) and I had to add three different iterations of essentially the same package to the Azure Artifacts feed. It's running again now.

Merged via the queue into PowerShell:main with commit a8b28e0 Nov 13, 2024
@o-l-a-v o-l-a-v deleted the fix-snippet-json-file branch November 13, 2024 23:07
@andyleejordan andyleejordan added the Issue-Bug A bug to squash. label Nov 15, 2024
@Cydroz Cydroz mentioned this pull request Jan 6, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Bug A bug to squash.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in foreach-progress snippet

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.