Fix PowerShell 7.2 E2E unit test for last change#2135
Merged
andyleejordan merged 1 commit intoFeb 12, 2024
mainPowerShell/PowerShellEditorServices:mainfrom
andyleejordan/fix-testPowerShell/PowerShellEditorServices:andyleejordan/fix-testCopy head branch name to clipboard
Merged
Fix PowerShell 7.2 E2E unit test for last change#2135andyleejordan merged 1 commit intomainPowerShell/PowerShellEditorServices:mainfrom andyleejordan/fix-testPowerShell/PowerShellEditorServices:andyleejordan/fix-testCopy head branch name to clipboard
andyleejordan merged 1 commit into
mainPowerShell/PowerShellEditorServices:mainfrom
andyleejordan/fix-testPowerShell/PowerShellEditorServices:andyleejordan/fix-testCopy head branch name to clipboard
Conversation
Member
Author
|
CI missed it because it's a real edge case that requires the end-to-end tests to run with the path explicitly set to use PowerShell 7.2 or 7.3 (since the path given in the build script is just "pwsh") and we somehow got an image for the PR and merge group that had 7.4, and then one for the push to main after the merge with 7.2. Confirmed by looking at the runs' linked image information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2115 added a new error message when no completion is returned (such as when it was interrupted) and our test covering a specific bug with PowerShell 7.2 was not updated. Investigating how CI missed this.