Added null check to GetCompletionsAsync#2115
Merged
andyleejordan merged 1 commit intoFeb 12, 2024
PowerShell:mainPowerShell/PowerShellEditorServices:mainfrom
dkattan:hotfix/null-reference-on-private-psprovider-completiondkattan/PowerShellEditorServices:hotfix/null-reference-on-private-psprovider-completionCopy head branch name to clipboard
Merged
Added null check to GetCompletionsAsync#2115andyleejordan merged 1 commit intoPowerShell:mainPowerShell/PowerShellEditorServices:mainfrom dkattan:hotfix/null-reference-on-private-psprovider-completiondkattan/PowerShellEditorServices:hotfix/null-reference-on-private-psprovider-completionCopy head branch name to clipboard
GetCompletionsAsync#2115andyleejordan merged 1 commit into
PowerShell:mainPowerShell/PowerShellEditorServices:mainfrom
dkattan:hotfix/null-reference-on-private-psprovider-completiondkattan/PowerShellEditorServices:hotfix/null-reference-on-private-psprovider-completionCopy head branch name to clipboard
Conversation
andyleejordan
requested changes
Dec 15, 2023
andyleejordan
left a comment
Member
There was a problem hiding this comment.
Good catch, just need to fix up what's now dead code around it.
b5f2942 to
9efac1c
Compare
andyleejordan
approved these changes
Feb 12, 2024
9efac1c to
5a4dc37
Compare
Member
LMAO. |
GetCompletionsAsync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Occasionally TabExpansion2 may return null. This could be due to a custom implementation of TabExpansion2 or an underlying issue with the FileSystemProvider or LocationGlobber.
When this happens the value of commandCompletion is not assigned and remains null. This causes a NullReferenceException to be thrown when commandCompletion.ReplacementLength is accessed in the subsequent call to LogTrace.
PR Context