Allow passing just a dash as an arg to a file via pwsh#9479
Merged
Merged
Allow passing just a dash as an arg to a file via pwsh#9479
Conversation
TravisEz13
approved these changes
Apr 26, 2019
Member
Author
|
@PoshChan please retry linux, macos |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
iSazonov
reviewed
Apr 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When processing a file (implicitly or via
-File), it looks at the remainings args and constructs parameters to pass to the pipeline. When the first character is a-, it assumes it's a parameter and uses the remainder to be the name of the parameter. If it's a single dash, it ends up being an empty string for the name. This causes the parameter binder to throw which then causes the console host to crash.Fix is to detect that it's a single dash and pass that as an unnamed parameter which gets handled correctly.
PR Context
Fix #9362
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.